Case light menu (3rd attempt)

[Kaibob2]

Github seems to be for Pros only :)
Referenced to this #5194 (and this #5243 because i don't understand github) i implemented a (definable) Menu entry on the main screen to toggle the case lights. I had this long before the #define CASE_LIGHT_PIN 4 and always found it extremely useful to be able to switch off the case light from by LCD. The host is shut down most of the time, so if #define CASE_LIGHT_DEFAULT_ON is enabled there is no way to switch of the case light if the printer is printing for 20 hours.

[thinkyhead]

Github seems to be for Pros only :)

Github helpfully provides great documentation. And Google provides a means to find more. The time spent struggling could be the time spent learning. Just as time spent trying to avoid effort now could be time spent learning to reduce effort forever. I personally recommend http://learngitbranching.js.org/ for a start.

[thinkyhead]

So close! Add a blank line above and restore the blank line after, and we're good!

[Kaibob2]

Like this?

[Kaibob2]

What's wrong here, do I have to change anything before this gets merged?

[ghost]

Maybe removing unnecessary spaces and squash are needed?

remove unnecessary spaces by text editor, and save	commit	open a git shell	git rebase -i HEAD~7

Then memopad is opend	edit and close (save)	done.	upload to web by git push -f

Result: https://github.com/esenapaj/Marlin/tree/CaseLightMenu

[Kaibob2]

@esenapaj I think i got i right now finally. Many thanks for the great guideline. I guess i wouldn't have made it without your advice. It's so easy...if you know how.

[ghost]

I'm glad that it works, but I'm sorry but it looks like that it needs fixing.
Unnecessary spaces should has been removed, but blank line is still needed.
And, new line at end ofultralcd.cpp is removed for some reason, it needs to be restored.
Needed altering is this.
https://github.com/esenapaj/Marlin/commit/3aab14521659e0e8b9f5c5edbdc5593f81944bb6

If you are thinking that you aren't sure how to fix it, there is also a way to copy my commit.

git remote add temporary https://github.com/esenapaj/Marlin	git fetch temporary	done.	select "temporary/CaseLightMenu"

click SHA, then it's copied to clipboard	return to "CaseLightMenu"	git cherry-pick and Ctrl + v	done.

git rebase -i HEAD~3	edit and close (save)	upload to web by git push -f

git remote rm temporary	select "temporary/CaseLightMenu"	delete "temporary/CaseLightMenu"

[Kaibob2]

Ay, i think i'm on my way messing it all up completely. But i won't give up. I only have to drive home from work :)

[ghost]

Nice fighting spirits... Yes, it's still recoverable.
When you use

git reset --hard HEAD~

, top of commit is vanished.

If you want to erase the first three commits,

git reset --hard HEAD~3

.

Or, another way for erasing commits available.

git rebase -i HEAD~5	Then memopad is opend	edit and close (save)	vanished.

[stigjoergensen]

@esenapaj I really like all these screen shots... and appreciate them so very much...

Could i ask a huge favor... write them up in a guide on how to use github with marlin and your local fork - it would be a huge help for many i think - and i think @thinkyhead or other could have them in the main wiki for everybody to find easily...

Thanks
/Stig

[Kaibob2]

@esenapaj Not completely sure, but i think i've got it now. fingerscrossed

[Kaibob2]

Puh, this was a tough one.
@esenapaj @thinkyhead Thanks a lot for your patience. I really learnt a lot about github today.
I already have another PR in mind, but i'm a little uncertain if it will become a disaster like this one...

[thinkyhead]

@Kaibob2 Practice makes perfect! If you have a BASH command line installed on your system (or can add one), I've written a few helper scripts that I find invaluable for working on Marlin. See #3567