Skip to content
This repository has been archived by the owner on Jan 3, 2022. It is now read-only.

v2.0.0 #84

Merged
merged 2 commits into from
Mar 14, 2020
Merged

v2.0.0 #84

merged 2 commits into from
Mar 14, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Mar 13, 2020 •
edited
Loading

@rekmarks rekmarks requested a review from danfinlay March 14, 2020 16:42
whymarrh
whymarrh suggested changes Mar 14, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #82 is a breaking change, technically, so we should make this 2.0.

We can either update this PR & title or create a new one.

@rekmarks rekmarks changed the title v1.1.0 v2.0.0 Mar 14, 2020
@rekmarks rekmarks requested a review from whymarrh March 14, 2020 17:15
whymarrh
whymarrh approved these changes Mar 14, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 7469821 into master Mar 14, 2020
@rekmarks rekmarks deleted the version-bump branch March 14, 2020 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@danfinlay danfinlay Awaiting requested review from danfinlay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @whymarrh