Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WebAssembly endowment factory #459

Merged
merged 2 commits into from
May 14, 2022
Merged

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented May 14, 2022

Node landed WebAssembly.compileStreaming and instantiateStreaming in nodejs/node#42701 and made it available in Node 18, so we no longer need to exclude these properties from our WebAssembly endowment. This PR therefore removes the WebAssembly endowment factory, which will now be included in whatever form it exists on the execution environment root realm global.

@rekmarks rekmarks requested a review from a team as a code owner May 14, 2022 19:19
@rekmarks rekmarks mentioned this pull request May 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2022

Codecov Report

Merging #459 (02d8de5) into main (31e1556) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   81.37%   81.28%   -0.10%     
==========================================
  Files          69       68       -1     
  Lines        2132     2121      -11     
  Branches      368      368              
==========================================
- Hits         1735     1724      -11     
  Misses        373      373              
  Partials       24       24              
Impacted Files Coverage Δ
...cution-environments/src/common/endowments/index.ts 91.42% <100.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e1556...02d8de5. Read the comment docs.

@rekmarks rekmarks merged commit def4667 into main May 14, 2022
@rekmarks rekmarks deleted the remove-wasm-endowment-factory branch May 14, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants