Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasmJS target to the Cache module #605

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Feb 26, 2024

Description

Adds the wasmJs target to the cache module.

A bit of context: we are currently looking at using cache as a dependency to apollo-kotlin's in-memory cache to improve performance with concurrency. Apollo Kotlin has the wasm target enabled so this change would come in handy for us.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test Plan

Added a few basic tests for Cache, and ensured ./gradlew :cache:wasmJsTest passes

Checklist:

Before submitting your PR, please review and check all of the following:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    • Didn't see a list of targets in the documentation, so didn't touch anything - let me know if I missed it
  • My changes generate no new warnings
  • I have added tests that prove my change is effective
  • New and existing unit tests pass locally with my changes

Additional Notes:

  • Also adds the target to core since it's a dependency of cache
  • I had to upgrade a few dependencies which resulted in a few tweaks to the gradle files
  • Also had to specify Java 11 as the target - using 17 triggers KT-60197 (see also this one)

Signed-off-by: BoD <BoD@JRAF.org>
Copy link
Collaborator

@matt-ramotar matt-ramotar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this looks good to me. I need to reset the version in gradle.properties to a snapshot. Will stamp after 👍🏽

Copy link
Collaborator

@matt-ramotar matt-ramotar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Keep us posted on how it goes

@matt-ramotar matt-ramotar merged commit b7aa329 into MobileNativeFoundation:main Feb 28, 2024
1 check passed
matt-ramotar added a commit that referenced this pull request Jun 29, 2024
Our CI checks have been failing since #605. Changes in this PR:
- Bumping to Kotlin 2.0.0
- Bumping to ktlint 12.1.0
- Bumping to java 17
- Adding lint baselines
- Removing node overrides
---------
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants