fix(timeout): fix syntax error #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `:` was causing a syntax error to be thrown. It seems that colon and the "User-Agent" bit was unnecessary since the header is already declared as `'User-Agent'`.
|
Now that is a properly stupid copy/paste mistake. I wonder why I didn't catch that myself :'( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
:was causing a syntax error to be thrown. It seems that colon and the "User-Agent" bit was unnecessary since the header is already declared as'User-Agent'.@Munter tried this on webpack/webpack.js.org#1582 and got the syntax error. You can check the build there to see what I mean. Happy to try again once the this is merged/resolved.