build statically-linked sui-node for testing on glibc-based hosts #18611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
bmwill
reviewed
Jul 11, 2024
| ENV GIT_REVISION=${GIT_REVISION} | ||
| ENV PROFILE=${PROFILE} | ||
|
|
||
| RUN --network=none cargo build --frozen --profile ${PROFILE} --bin sui-node | ||
| RUN --network=none cargo build --target x86_64-unknown-linux-musl --frozen --profile ${PROFILE} --bin sui-node |
There was a problem hiding this comment.
Is this part needed? or is the fixing of the rust flags enough?
There was a problem hiding this comment.
it actually is needed:
=> CACHED [build 7/8] COPY --from=linux-headers . / 0.0s
=> ERROR [build 8/8] RUN --network=none cargo build --frozen --profile release --bin sui-node 5.1s
------
> [build 8/8] RUN --network=none cargo build --frozen --profile release --bin sui-node:
5.010 error: cannot produce proc-macro for `ark-ff-asm v0.4.2` as the target `x86_64-unknown-linux-musl` does not support these crate types
------
Dockerfile:67
--------------------
65 | ENV PROFILE=${PROFILE}
66 |
67 | >>> RUN --network=none cargo build --frozen --profile ${PROFILE} --bin sui-node
68 |
69 | FROM scratch AS install
--------------------
ERROR: failed to solve: process "/bin/sh -c cargo build --frozen --profile ${PROFILE} --bin sui-node" did not complete successfully: exit code: 101
(other references to this issue of needing to specify --target
rust-lang/rust#78210 (comment)
https://msfjarvis.dev/posts/building-static-rust-binaries-for-linux/
The reason behind this seems to be a bug with cargo, where the RUSTFLAGS are applied to the target platform only when --target is explicitly provided
bmwill
approved these changes
Jul 12, 2024
|
relates to: #13476 |
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
Jul 29, 2024
…stenLabs#18611) ## Description Update Deterministic Sui Build to compile a statically-linked binary. StageX uses `musl` for compiling `sui-node`. In order for this to run the `sui-node` binary directly on glibc-based linux macines, it must be statically linked. ## Test plan Cherry-pick commit to `testnet` branch and test on a private testnet. * build docker image * extract `sui-node` binary * confirm statically linked (run `file` on mac, `ldd` on linux) * upload to baremetal test server + run * check build is still deterministic from github action build, linux machine, macOS machine --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Deterministic Sui Build to compile a statically-linked binary.
StageX uses
muslfor compilingsui-node.In order for this to run the
sui-nodebinary directly on glibc-based linux macines, it must be statically linked.Test plan
Cherry-pick commit to
testnetbranch and test on a private testnet.sui-nodebinaryfileon mac,lddon linux)Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.