Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate vector functions #81

Merged
merged 8 commits into from
Jul 7, 2022
Merged

Conversation

scarlehoff
Copy link
Member

@scarlehoff scarlehoff commented Jul 5, 2022

This feature could already be implemented by using the same techniques as in the example for multiple integrals: https://github.com/N3PDF/vegasflow/blob/master/examples/multiple_integrals.py

but since this exploits the tensor structure of all TensorFlow quantities I thought it would be nice to have it "official supported". Specially since there are examples of this already in the wild.

Need to

  • Ensure that this doesn't harm performance for normal integrations
  • Add docs to explain how it should be used (and possible caveats)
  • Ensure the test include the new features

@scarlehoff scarlehoff added enhancement New feature or request 1.3 labels Jul 5, 2022
@scarlehoff scarlehoff force-pushed the multidimensional_outuput_integrands branch from fff8efa to e30be6d Compare July 7, 2022 10:18
@scarlehoff scarlehoff merged commit 73e9dd5 into master Jul 7, 2022
@scarlehoff scarlehoff deleted the multidimensional_outuput_integrands branch July 7, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant