Handle a non-existent field in an array #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was giving me an error, since I had several records for which a particular field was not defined. Since I use a schema-less DB (MongoDB), this field doesn't even exist with a null value. `data_get` performs an `array_key_exists` check before attempting to use `$part` as an index for the `$res` array.
This entire method could actually be replaced with data_get for simplicity, since this is what Laravel uses internally to retrieve values in dot notation.
```php
protected function extractCellValue($fieldName)
{
try {
return data_get($this->src, $fieldName);
} catch (Exception $e) {
throw new RuntimeException(
"Can't read '$fieldName' property from DataRow",
0,
$e
);
}
}
```
|
Hi! |
|
Released in v1.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was giving me an error, since I had several records for which a particular field was not defined. Since I use a schema-less DB (MongoDB), this field doesn't even exist with a null value.
data_getperforms anarray_key_existscheck before attempting to use$partas an index for the$resarray.This entire method could actually be replaced with data_get for simplicity, since this is what Laravel uses internally to retrieve values in dot notation.