Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdf5-mpi,hdf5-cpp,hdf5-fortran,hdf5-threadsafe: remove appendToName to have a consistent package name for repology #160065

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

Stunkymonkey
Copy link
Contributor

Motivation for this change

#68519
I believe @davidak, @jtojnar, @FRidh should confirm this. Maybe there is a more elegant method then using lib.optionalString.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Feb 15, 2022

The change looks good to me, however, the commit message should explain why this change is needed. The linked issue states the motivation.

@Stunkymonkey
Copy link
Contributor Author

better?

@Stunkymonkey Stunkymonkey changed the title hdf5-mpi,hdf5-cpp,hdf5-fortran,hdf5-threadsafe: remove appendToName hdf5-mpi,hdf5-cpp,hdf5-fortran,hdf5-threadsafe: remove appendToName to have a consistent package name for repology Feb 15, 2022
@Artturin Artturin merged commit 723c7c9 into NixOS:master Feb 21, 2022
@Stunkymonkey Stunkymonkey deleted the hdf5-appendToName branch April 4, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants