Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.05] hedgedoc: apply patch for CVE-2023-38487 #246274

Closed
wants to merge 1 commit into from
Closed

[23.05] hedgedoc: apply patch for CVE-2023-38487 #246274

wants to merge 1 commit into from

Conversation

yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented Jul 31, 2023

Description of changes

See #246259

Updating to 1.9.8+ requires entirely reworking the packaging because it no
longer uses Yarn 1.x lockfiles.
Instead we just apply the patch.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Updating to 1.9.8+ requires entirely reworking the packaging because it no
longer uses Yarn 1.x lockfiles.
Instead we just apply the patch.
@yu-re-ka yu-re-ka changed the title hedgedoc: apply patch for CVE-2023-38487 [23.05] hedgedoc: apply patch for CVE-2023-38487 Jul 31, 2023
@SuperSandro2000
Copy link
Member

We are missing two patch releases with other fixes which we should backport instead of this.

The package rework should be completely ignorable for most people and unless you overlaying hedgedoc I don't see how it could break things.

@yu-re-ka
Copy link
Contributor Author

Technically these are patch/fix releases, but the content of those releases - removing support for certain nodejs and yarn versions, and changes to the user interface - is barely a patch/fix release kind of change.
The diff from 1.9.7 to 1.9.9 is 51 changed files with 18,774 additions and 12,560 deletions.
This is why I would say the risk of breaking stuff is quite high, and we should only backport important bug/security fixes on top of 1.9.7 for NixOS 23.05.

@SuperSandro2000
Copy link
Member

and changes to the user interface

I am not sure to which change you are referring.

removing support for certain nodejs and yarn versions,

Yeah, because it was necessary to fix bugs in dependency resolution. I am sure they didn't take that decision lightly. 23.05 is on nodejs_18 and I already tested the update on a real deployment and it went smooth as butter.

I am the maintainer of hedgedoc and I am against doing such patchery since I can't test it and I don't expect upstream to provide any kind of help in case anything doesn't work.

I have created #246327 as an alternative to this and I kindly asking to not merge this PR.

@yu-re-ka yu-re-ka closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants