python310Packages.onnx: switch to protobuf 4.x #255077

happysalada · 2023-09-14T09:02:55Z

Description of changes

I'm trying to switch the protobuf version used in onnx to 4.x
a new dependency is required (abseil-cpp), and there are several warning messages about needing c++14.
I'm stuck though, during the compilation of onnx, c++11 is used, I don't know how to switch the version to c++14, I've tried adding the c++14 flags, and I can see in the build the CXX flags, however I still get warnings that c++11 is used.
@benxiao this should fix the mmcv build, however, I'm not sure how to get this unstuck.

@acairncross maybe you know more about this ?

if anyone is interested, I think it's just a matter of using c++14 here.

I had a small discussion upstream to talk what it would take for an upgrade.
onnx/onnx#5579 (comment)

Things done

acairncross · 2023-09-14T22:50:04Z

The problem seems to be that although Onnx's main branch does both use C++ 14 by default and makes the C++ version configurable via command line arguments to cmake, on the v1.14.1 tag it uses C++ 11 and isn't configurable: https://github.com/onnx/onnx/blob/v1.14.1/CMakeLists.txt#L61

We could try to use fetchpatch with the upstream patches that bump/make the C++ version configurable (1, 2) but they don't seem to apply cleanly, so I'd suggest just the hackier solution of adding a substituteInPlace:

substituteInPlace CMakeLists.txt \
  --replace 'CMAKE_CXX_STANDARD 11' 'CMAKE_CXX_STANDARD 17'

(I think C++ 14 isn't sufficient for our version of abseil btw, so using C++ 17 here)

happysalada · 2023-09-15T10:06:13Z

@acairncross thanks a lot for your idea, it worked flawlessly!
I went with c++ 14 since they suggested upstream that this is what they use and recommend.
I tested on x86_64-darwin and I'm going to start a nixpkgs-review on linux-x86_64.
I suggest we keep the substitute in place and check with the next version if it's still needed.

happysalada · 2023-09-15T10:14:33Z

Result of nixpkgs-review pr 255077 run on x86_64-linux 1

6 packages marked as broken and skipped:

piper-train
piper-train.dist
python310Packages.insightface
python310Packages.insightface.dist
python311Packages.insightface
python311Packages.insightface.dist

65 packages failed to build:

aitrack
deface
deface.dist
easyocr (python310Packages.easyocr)
easyocr.dist (python310Packages.easyocr.dist)
livecaptions
migraphx
monado
obs-studio-plugins.obs-backgroundremoval
onnxruntime
onnxruntime.dev
onnxruntime.dist
opencomposite-helper
piper-phonemize
piper-tts
python310Packages.fastembed
python310Packages.fastembed.dist
python310Packages.ffcv
python310Packages.ffcv.dist
python310Packages.invisible-watermark
python310Packages.invisible-watermark.dist
python310Packages.mmcv
python310Packages.mmcv.dist
python310Packages.onnx
python310Packages.onnx.dist
python310Packages.onnxconverter-common
python310Packages.onnxconverter-common.dist
python310Packages.onnxmltools
python310Packages.onnxmltools.dist
python310Packages.onnxruntime
python310Packages.onnxruntime-tools
python310Packages.onnxruntime-tools.dist
python310Packages.onnxruntime.dist
python310Packages.paddle2onnx
python310Packages.paddle2onnx.dist
python310Packages.piper-phonemize
python310Packages.piper-phonemize.dist
python310Packages.pytorch-pfn-extras
python310Packages.pytorch-pfn-extras.dist
python310Packages.skl2onnx
python310Packages.skl2onnx.dist
python311Packages.easyocr
python311Packages.easyocr.dist
python311Packages.fastembed
python311Packages.fastembed.dist
python311Packages.invisible-watermark
python311Packages.invisible-watermark.dist
python311Packages.mmcv
python311Packages.mmcv.dist
python311Packages.onnx
python311Packages.onnx.dist
python311Packages.onnxconverter-common
python311Packages.onnxconverter-common.dist
python311Packages.onnxmltools
python311Packages.onnxmltools.dist
python311Packages.onnxruntime
python311Packages.onnxruntime-tools
python311Packages.onnxruntime-tools.dist
python311Packages.onnxruntime.dist
python311Packages.piper-phonemize
python311Packages.piper-phonemize.dist
python311Packages.pytorch-pfn-extras
python311Packages.pytorch-pfn-extras.dist
python311Packages.skl2onnx
python311Packages.skl2onnx.dist

happysalada · 2023-09-15T10:16:03Z

alright, the failure I get on linux it seems is

.cc.o
onnx> [ 97%] Building CXX object CMakeFiles/onnx_gtests.dir/onnx/test/cpp/test_main.cc.o
onnx> [ 98%] Linking CXX executable onnx_gtests
onnx> /nix/store/rhhll3vwpj38ri72ahrrrvcbkhz4fhh6-binutils-2.40/bin/ld: CMakeFiles/onnx_
gtests.dir/onnx/test/cpp/data_propagation_test.cc.o: in function `onnx::Test::DataPropag
ationImplTest_SymbolicShapeTest_Test::TestBody()':
onnx> data_propagation_test.cc:(.text+0x310f): undefined reference to `google::protobuf:
:internal::ArenaStringPtr::Set(absl::lts_20230125::string_view, google::protobuf::Arena*
)'
onnx> /nix/store/rhhll3vwpj38ri72ahrrrvcbkhz4fhh6-binutils-2.40/bin/ld: CMakeFiles/onnx_
gtests.dir/onnx/test/cpp/function_context_test.cc.o: in function `onnx::Test::FunctionAP
ITest_ContextDependentFunctionTest_Test::TestBody()':
onnx> function_context_test.cc:(.text+0x36fb): undefined reference to `google::protobuf:
:internal::ArenaStringPtr::Set(absl::lts_20230125::string_view, google::protobuf::Arena*
)'
onnx> /nix/store/rhhll3vwpj38ri72ahrrrvcbkhz4fhh6-binutils-2.40/bin/ld: CMakeFiles/onnx_
gtests.dir/onnx/test/cpp/function_context_test.cc.o: in function `onnx::Test::FunctionAP
ITest_TypeContextTest_Test::TestBody()':
onnx> function_context_test.cc:(.text+0x48bc): undefined reference to `google::protobuf:
:internal::ArenaStringPtr::Set(absl::lts_20230125::string_view, google::protobuf::Arena*
)'
onnx> /nix/store/rhhll3vwpj38ri72ahrrrvcbkhz4fhh6-binutils-2.40/bin/ld: CMakeFiles/onnx_
onnx> function_verify_test.cc:(.text+0x4e26): undefined reference to `google::protobuf::'
onnx> /nix/store/rhhll3vwpj38ri72ahrrrvcbkhz4fhh6-binutils-2.40/bin/ld: CMakeFiles/onnx_gtests.dir/onnx/test/cpp/function_verify_test.cc.o: in function `onnx::Test::RegisterFunctionSchema()':
onnx> function_verify_test.cc:(.text+0x5f42): undefined reference to `google::protobuf::internal::ArenaStringPtr::Set(absl::lts_20230125::string_view, google::protobuf::Arena*)'
onnx> /nix/store/rhhll3vwpj38ri72ahrrrvcbkhz4fhh6-binutils-2.40/bin/ld: CMakeFiles/onnx_gtests.dir/onnx/test/cpp/function_verify_test.cc.o:function_verify_test.cc:(.text+0x5f7f): more undefined references to `google::protobuf::internal::ArenaStringPtr::Set(absl::lts_20230125::string_view, google::protobuf::Arena*)' follow
onnx> collect2: error: ld returned 1 exit status
onnx> make[2]: *** [CMakeFiles/onnx_gtests.dir/build.make:246: onnx_gtests] Error 1
onnx> make[1]: *** [CMakeFiles/Makefile2:252: CMakeFiles/onnx_gtests.dir/all] Error 2
onnx> make[1]: *** Waiting for unfinished jobs....

acairncross · 2023-09-15T13:16:11Z

I don't know what the cause of the linker error is, but I have found by experimenting that setting CMAKE_CXX_STANDARD 17 and removing the cxxStandard override for abseil makes the build succeed. I don't necessarily suggest that as a solution since I agree that C++ 14 should be sufficient.

jcwchen

Seems related to abseil/abseil-cpp#634

happysalada · 2023-09-16T07:46:01Z

I've checked a bit and protobuf itself seems to be compiled with c++14
https://github.com/protocolbuffers/protobuf/blob/main/CMakeLists.txt#L187
the error pointed at seems to happen when one target is compiled with a different c++ version as the others.
https://github.com/abseil/abseil-cpp/blob/master/FAQ.md#what-is-abi-and-why-dont-you-recommend-using-a-pre-compiled-version-of-abseil
This is a little puzzling to me as all the c++ versions used here are 14.

happysalada · 2023-09-16T08:44:59Z

@andersk sorry to bring you into this, (feel free to ignore if you don't have time).
Given the problems we have, I found this option for abseil https://github.com/abseil/abseil-cpp/blob/master/CMakeLists.txt#L73C8-L73C30
I thought I would give a go at enabling it to see if we still get an error on building onnx.
I'm shooting from the hip here.
If you have any ideas, I'm happy to try other things.

happysalada · 2023-09-16T11:02:09Z

Result of nixpkgs-review pr 255077 run on x86_64-linux 1

6 packages marked as broken and skipped:

piper-train
piper-train.dist
python310Packages.insightface
python310Packages.insightface.dist
python311Packages.insightface
python311Packages.insightface.dist

65 packages failed to build:

aitrack
deface
deface.dist
easyocr (python310Packages.easyocr)
easyocr.dist (python310Packages.easyocr.dist)
livecaptions
migraphx
monado
obs-studio-plugins.obs-backgroundremoval
onnxruntime
onnxruntime.dev
onnxruntime.dist
opencomposite-helper
piper-phonemize
piper-tts
python310Packages.fastembed
python310Packages.fastembed.dist
python310Packages.ffcv
python310Packages.ffcv.dist
python310Packages.invisible-watermark
python310Packages.invisible-watermark.dist
python310Packages.mmcv
python310Packages.mmcv.dist
python310Packages.onnx
python310Packages.onnx.dist
python310Packages.onnxconverter-common
python310Packages.onnxconverter-common.dist
python310Packages.onnxmltools
python310Packages.onnxmltools.dist
python310Packages.onnxruntime
python310Packages.onnxruntime-tools
python310Packages.onnxruntime-tools.dist
python310Packages.onnxruntime.dist
python310Packages.paddle2onnx
python310Packages.paddle2onnx.dist
python310Packages.piper-phonemize
python310Packages.piper-phonemize.dist
python310Packages.pytorch-pfn-extras
python310Packages.pytorch-pfn-extras.dist
python310Packages.skl2onnx
python310Packages.skl2onnx.dist
python311Packages.easyocr
python311Packages.easyocr.dist
python311Packages.fastembed
python311Packages.fastembed.dist
python311Packages.invisible-watermark
python311Packages.invisible-watermark.dist
python311Packages.mmcv
python311Packages.mmcv.dist
python311Packages.onnx
python311Packages.onnx.dist
python311Packages.onnxconverter-common
python311Packages.onnxconverter-common.dist
python311Packages.onnxmltools
python311Packages.onnxmltools.dist
python311Packages.onnxruntime
python311Packages.onnxruntime-tools
python311Packages.onnxruntime-tools.dist
python311Packages.onnxruntime.dist
python311Packages.piper-phonemize
python311Packages.piper-phonemize.dist
python311Packages.pytorch-pfn-extras
python311Packages.pytorch-pfn-extras.dist
python311Packages.skl2onnx
python311Packages.skl2onnx.dist

happysalada · 2023-09-16T11:17:05Z

I've also tried not setting the cxx_standard in abseil to see, but it fails even earlier.

happysalada · 2023-09-16T11:34:48Z

Result of nixpkgs-review pr 255077 run on x86_64-linux 1

6 packages marked as broken and skipped:

piper-train
piper-train.dist
python310Packages.insightface
python310Packages.insightface.dist
python311Packages.insightface
python311Packages.insightface.dist

65 packages failed to build:

aitrack
deface
deface.dist
easyocr (python310Packages.easyocr)
easyocr.dist (python310Packages.easyocr.dist)
livecaptions
migraphx
monado
obs-studio-plugins.obs-backgroundremoval
onnxruntime
onnxruntime.dev
onnxruntime.dist
opencomposite-helper
piper-phonemize
piper-tts
python310Packages.fastembed
python310Packages.fastembed.dist
python310Packages.ffcv
python310Packages.ffcv.dist
python310Packages.invisible-watermark
python310Packages.invisible-watermark.dist
python310Packages.mmcv
python310Packages.mmcv.dist
python310Packages.onnx
python310Packages.onnx.dist
python310Packages.onnxconverter-common
python310Packages.onnxconverter-common.dist
python310Packages.onnxmltools
python310Packages.onnxmltools.dist
python310Packages.onnxruntime
python310Packages.onnxruntime-tools
python310Packages.onnxruntime-tools.dist
python310Packages.onnxruntime.dist
python310Packages.paddle2onnx
python310Packages.paddle2onnx.dist
python310Packages.piper-phonemize
python310Packages.piper-phonemize.dist
python310Packages.pytorch-pfn-extras
python310Packages.pytorch-pfn-extras.dist
python310Packages.skl2onnx
python310Packages.skl2onnx.dist
python311Packages.easyocr
python311Packages.easyocr.dist
python311Packages.fastembed
python311Packages.fastembed.dist
python311Packages.invisible-watermark
python311Packages.invisible-watermark.dist
python311Packages.mmcv
python311Packages.mmcv.dist
python311Packages.onnx
python311Packages.onnx.dist
python311Packages.onnxconverter-common
python311Packages.onnxconverter-common.dist
python311Packages.onnxmltools
python311Packages.onnxmltools.dist
python311Packages.onnxruntime
python311Packages.onnxruntime-tools
python311Packages.onnxruntime-tools.dist
python311Packages.onnxruntime.dist
python311Packages.piper-phonemize
python311Packages.piper-phonemize.dist
python311Packages.pytorch-pfn-extras
python311Packages.pytorch-pfn-extras.dist
python311Packages.skl2onnx
python311Packages.skl2onnx.dist

happysalada · 2023-09-16T12:03:23Z

in this latest try I've tried setting c++ to 17 in onnx and removing the cxx standard in abseil, but that didn't work on linux.

acairncross · 2023-09-16T12:53:36Z

That's strange, I've just successfully built python310Packages.onnx on my Linux machine from your most recent commit a28fafd

happysalada · 2023-09-16T15:31:00Z

Result of nixpkgs-review pr 255077 run on x86_64-linux 1

6 packages marked as broken and skipped:

piper-train
piper-train.dist
python310Packages.insightface
python310Packages.insightface.dist
python311Packages.insightface
python311Packages.insightface.dist

16 packages failed to build:

python310Packages.mmcv
python310Packages.mmcv.dist
python310Packages.onnxconverter-common
python310Packages.onnxconverter-common.dist
python310Packages.onnxmltools
python310Packages.onnxmltools.dist
python310Packages.skl2onnx
python310Packages.skl2onnx.dist
python311Packages.mmcv
python311Packages.mmcv.dist
python311Packages.onnxconverter-common
python311Packages.onnxconverter-common.dist
python311Packages.onnxmltools
python311Packages.onnxmltools.dist
python311Packages.skl2onnx
python311Packages.skl2onnx.dist

49 packages built:

aitrack
deface
deface.dist
easyocr (python310Packages.easyocr)
easyocr.dist (python310Packages.easyocr.dist)
livecaptions
migraphx
monado
obs-studio-plugins.obs-backgroundremoval
onnxruntime
onnxruntime.dev
onnxruntime.dist
opencomposite-helper
piper-phonemize
piper-tts
python310Packages.fastembed
python310Packages.fastembed.dist
python310Packages.ffcv
python310Packages.ffcv.dist
python310Packages.invisible-watermark
python310Packages.invisible-watermark.dist
python310Packages.onnx
python310Packages.onnx.dist
python310Packages.onnxruntime
python310Packages.onnxruntime-tools
python310Packages.onnxruntime-tools.dist
python310Packages.onnxruntime.dist
python310Packages.paddle2onnx
python310Packages.paddle2onnx.dist
python310Packages.piper-phonemize
python310Packages.piper-phonemize.dist
python310Packages.pytorch-pfn-extras
python310Packages.pytorch-pfn-extras.dist
python311Packages.easyocr
python311Packages.easyocr.dist
python311Packages.fastembed
python311Packages.fastembed.dist
python311Packages.invisible-watermark
python311Packages.invisible-watermark.dist
python311Packages.onnx
python311Packages.onnx.dist
python311Packages.onnxruntime
python311Packages.onnxruntime-tools
python311Packages.onnxruntime-tools.dist
python311Packages.onnxruntime.dist
python311Packages.piper-phonemize
python311Packages.piper-phonemize.dist
python311Packages.pytorch-pfn-extras
python311Packages.pytorch-pfn-extras.dist

happysalada · 2023-09-16T15:33:01Z

@acairncross by adding cxxstandard to 17 to abseil, compilation succeeds.
I am in favor of this change, it's weird, because protobuf is on c++14, but updating to latest protobuf is needed for mmcv fix and all the dependents. (@benxiao tried to fix mmcv but we ran into protobuf version incompatibilities).

@jcwchen let me know if you are against it, but I vote for proceeding with c++17.

(btw in the build failures, the mmcv failure is expected, it's missing a pybind11 dependency).

acairncross · 2023-09-16T21:06:49Z

Hm, it's not ideal that we don't really know why it works, but good that it does work.

I've got a bit more of an idea of what was going wrong with CMAKE_CXX_STANDARD 14 now, which is essentially that we're using abseil in a way that restricts the C++ standard that consumers of the library can use. #185865 and #196718 describe some of the problem. This patch, for example, makes the build with CMAKE_CXX_STANDARD 14 succeed.

diff --git a/pkgs/development/libraries/abseil-cpp/202301.nix b/pkgs/development/libraries/abseil-cpp/202301.nix
index da5f1fc029e1..6e7b10bdec19 100644
--- a/pkgs/development/libraries/abseil-cpp/202301.nix
+++ b/pkgs/development/libraries/abseil-cpp/202301.nix
@@ -32,6 +32,10 @@ stdenv.mkDerivation (finalAttrs: {
 
   buildInputs = [ gtest ];
 
+  postPatch = ''
+    substituteInPlace absl/base/options.h --replace 'ABSL_OPTION_USE_STD_STRING_VIEW 2' 'ABSL_OPTION_USE_STD_STRING_VIEW 0'
+  '';
+
   meta = with lib; {
     description = "An open-source collection of C++ code designed to augment the C++ standard library";
     homepage = "https://abseil.io/";

happysalada · 2023-09-16T22:53:50Z

Hey thanks for doing a lot of the digging !

If i read the previous PRs correctly, patching abseil was rejected by the maintainers. So we cant go the suggested route right ?

What do you think i add a comment describing what we went through and we keep it on the 17 version ?

acairncross · 2023-09-17T22:41:36Z

Yeah, going with the C++ 17 version is fine.

I think part of the reason we need to compile with C++ 17 is because abseil is compiled with C++ 17 by default, which causes it to use C++ 17 features. I don't really understand why we aren't needing to specify that protobuf also be compiled with C++ 17, or at least 14 despite the protobuf docs saying it's necessary.

Incidentally, I guess what went wrong with the attempt to compile both onnx and abseil (using cxxStandard) with C++ 14 in ea847b4 was that protobuf should have also been overridden to use the abseil compiled with C++ 14, although I'm not certain.

happysalada · 2023-09-18T08:20:06Z

The protobuf idea is an interesting one, let me go ask the protobuf maintainers, I'll open a PR and will tag you.

Are you okay to merge the current PR then ? (I just want to make sure).

acairncross

I think we've gotten to the bottom of this and this approach looks good to me 😃

pkgs/development/python-modules/onnx/default.nix

pkgs/top-level/python-packages.nix

happysalada · 2023-09-18T14:34:23Z

@acairncross I've taken care of your comments, let me know if you have more.

happysalada · 2023-09-18T19:10:03Z

Result of nixpkgs-review pr 255077 run on x86_64-darwin 1

22 packages marked as broken and skipped:

piper-train
piper-train.dist
python310Packages.faster-whisper
python310Packages.faster-whisper.dist
python310Packages.insightface
python310Packages.insightface.dist
python310Packages.piper-phonemize
python310Packages.piper-phonemize.dist
python310Packages.tf2onnx
python310Packages.tf2onnx.dist
python310Packages.unstructured-inference
python310Packages.unstructured-inference.dist
python311Packages.faster-whisper
python311Packages.faster-whisper.dist
python311Packages.insightface
python311Packages.insightface.dist
python311Packages.piper-phonemize
python311Packages.piper-phonemize.dist
python311Packages.tf2onnx
python311Packages.tf2onnx.dist
whisper-ctranslate2
whisper-ctranslate2.dist

51 packages failed to build:

deface
deface.dist
easyocr (python310Packages.easyocr)
easyocr.dist (python310Packages.easyocr.dist)
onnxruntime
onnxruntime.dev
onnxruntime.dist
python310Packages.fastembed
python310Packages.fastembed.dist
python310Packages.ffcv
python310Packages.ffcv.dist
python310Packages.invisible-watermark
python310Packages.invisible-watermark.dist
python310Packages.mmcv
python310Packages.mmcv.dist
python310Packages.onnx
python310Packages.onnx.dist
python310Packages.onnxconverter-common
python310Packages.onnxconverter-common.dist
python310Packages.onnxmltools
python310Packages.onnxmltools.dist
python310Packages.onnxruntime
python310Packages.onnxruntime-tools
python310Packages.onnxruntime-tools.dist
python310Packages.onnxruntime.dist
python310Packages.pytorch-pfn-extras
python310Packages.pytorch-pfn-extras.dist
python310Packages.skl2onnx
python310Packages.skl2onnx.dist
python311Packages.easyocr
python311Packages.easyocr.dist
python311Packages.fastembed
python311Packages.fastembed.dist
python311Packages.invisible-watermark
python311Packages.invisible-watermark.dist
python311Packages.mmcv
python311Packages.mmcv.dist
python311Packages.onnx
python311Packages.onnx.dist
python311Packages.onnxconverter-common
python311Packages.onnxconverter-common.dist
python311Packages.onnxmltools
python311Packages.onnxmltools.dist
python311Packages.onnxruntime
python311Packages.onnxruntime-tools
python311Packages.onnxruntime-tools.dist
python311Packages.onnxruntime.dist
python311Packages.pytorch-pfn-extras
python311Packages.pytorch-pfn-extras.dist
python311Packages.skl2onnx
python311Packages.skl2onnx.dist

happysalada · 2023-09-18T19:55:45Z

Result of nixpkgs-review pr 255077 run on x86_64-darwin 1

22 packages marked as broken and skipped:

piper-train
piper-train.dist
python310Packages.faster-whisper
python310Packages.faster-whisper.dist
python310Packages.insightface
python310Packages.insightface.dist
python310Packages.piper-phonemize
python310Packages.piper-phonemize.dist
python310Packages.tf2onnx
python310Packages.tf2onnx.dist
python310Packages.unstructured-inference
python310Packages.unstructured-inference.dist
python311Packages.faster-whisper
python311Packages.faster-whisper.dist
python311Packages.insightface
python311Packages.insightface.dist
python311Packages.piper-phonemize
python311Packages.piper-phonemize.dist
python311Packages.tf2onnx
python311Packages.tf2onnx.dist
whisper-ctranslate2
whisper-ctranslate2.dist

51 packages failed to build:

deface
deface.dist
easyocr (python310Packages.easyocr)
easyocr.dist (python310Packages.easyocr.dist)
onnxruntime
onnxruntime.dev
onnxruntime.dist
python310Packages.fastembed
python310Packages.fastembed.dist
python310Packages.ffcv
python310Packages.ffcv.dist
python310Packages.invisible-watermark
python310Packages.invisible-watermark.dist
python310Packages.mmcv
python310Packages.mmcv.dist
python310Packages.onnx
python310Packages.onnx.dist
python310Packages.onnxconverter-common
python310Packages.onnxconverter-common.dist
python310Packages.onnxmltools
python310Packages.onnxmltools.dist
python310Packages.onnxruntime
python310Packages.onnxruntime-tools
python310Packages.onnxruntime-tools.dist
python310Packages.onnxruntime.dist
python310Packages.pytorch-pfn-extras
python310Packages.pytorch-pfn-extras.dist
python310Packages.skl2onnx
python310Packages.skl2onnx.dist
python311Packages.easyocr
python311Packages.easyocr.dist
python311Packages.fastembed
python311Packages.fastembed.dist
python311Packages.invisible-watermark
python311Packages.invisible-watermark.dist
python311Packages.mmcv
python311Packages.mmcv.dist
python311Packages.onnx
python311Packages.onnx.dist
python311Packages.onnxconverter-common
python311Packages.onnxconverter-common.dist
python311Packages.onnxmltools
python311Packages.onnxmltools.dist
python311Packages.onnxruntime
python311Packages.onnxruntime-tools
python311Packages.onnxruntime-tools.dist
python311Packages.onnxruntime.dist
python311Packages.pytorch-pfn-extras
python311Packages.pytorch-pfn-extras.dist
python311Packages.skl2onnx
python311Packages.skl2onnx.dist

happysalada · 2023-09-18T19:58:41Z

my reviews failed twice because of disk space.
I just don't have enough space to make this review.
I've tested several times that the onnx package builds though, so I'm going to go ahead and merge this.

happysalada marked this pull request as draft September 14, 2023 09:03

happysalada requested a review from acairncross September 14, 2023 09:03

github-actions bot added the 6.topic: python label Sep 14, 2023

happysalada requested a review from fabaff September 14, 2023 09:03

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Sep 14, 2023

happysalada force-pushed the onnx_protobuf_4 branch from 9c00560 to ddee4ee Compare September 15, 2023 10:04

happysalada marked this pull request as ready for review September 15, 2023 10:04

jcwchen reviewed Sep 15, 2023

View reviewed changes

happysalada force-pushed the onnx_protobuf_4 branch from ddee4ee to ea847b4 Compare September 16, 2023 08:34

ofborg bot requested a review from andersk September 16, 2023 08:54

ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 and removed 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Sep 16, 2023

happysalada force-pushed the onnx_protobuf_4 branch from ea847b4 to 422e73b Compare September 16, 2023 10:52

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 501+ labels Sep 16, 2023

ofborg bot removed 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 labels Sep 16, 2023

happysalada force-pushed the onnx_protobuf_4 branch from 422e73b to a28fafd Compare September 16, 2023 11:29

happysalada force-pushed the onnx_protobuf_4 branch from a28fafd to c6cb6fe Compare September 16, 2023 14:55

acairncross suggested changes Sep 18, 2023

View reviewed changes

pkgs/development/python-modules/onnx/default.nix Show resolved Hide resolved

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved

python311Packages.onnx: protobuf 3.x -> 4.x

8e89290

happysalada force-pushed the onnx_protobuf_4 branch from c6cb6fe to 8e89290 Compare September 18, 2023 14:33

ofborg bot requested a review from acairncross September 18, 2023 15:36

acairncross approved these changes Sep 18, 2023

View reviewed changes

delroth added 12.approvals: 1 12.approved-by: package-maintainer labels Sep 18, 2023

happysalada merged commit 8e11eef into NixOS:master Sep 18, 2023
24 checks passed

happysalada deleted the onnx_protobuf_4 branch September 18, 2023 19:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python310Packages.onnx: switch to protobuf 4.x #255077

python310Packages.onnx: switch to protobuf 4.x #255077

happysalada commented Sep 14, 2023 •

edited

Loading

acairncross commented Sep 14, 2023

happysalada commented Sep 15, 2023

happysalada commented Sep 15, 2023

happysalada commented Sep 15, 2023

acairncross commented Sep 15, 2023

jcwchen left a comment

happysalada commented Sep 16, 2023

happysalada commented Sep 16, 2023

happysalada commented Sep 16, 2023

happysalada commented Sep 16, 2023

happysalada commented Sep 16, 2023

happysalada commented Sep 16, 2023

acairncross commented Sep 16, 2023

happysalada commented Sep 16, 2023

happysalada commented Sep 16, 2023 •

edited

Loading

acairncross commented Sep 16, 2023

happysalada commented Sep 16, 2023

acairncross commented Sep 17, 2023

happysalada commented Sep 18, 2023

acairncross left a comment

happysalada commented Sep 18, 2023

happysalada commented Sep 18, 2023

happysalada commented Sep 18, 2023

happysalada commented Sep 18, 2023

python310Packages.onnx: switch to protobuf 4.x #255077

python310Packages.onnx: switch to protobuf 4.x #255077

Conversation

happysalada commented Sep 14, 2023 • edited Loading

Description of changes

Things done

acairncross commented Sep 14, 2023

happysalada commented Sep 15, 2023

happysalada commented Sep 15, 2023

happysalada commented Sep 15, 2023

acairncross commented Sep 15, 2023

jcwchen left a comment

Choose a reason for hiding this comment

happysalada commented Sep 16, 2023

happysalada commented Sep 16, 2023

happysalada commented Sep 16, 2023

happysalada commented Sep 16, 2023

happysalada commented Sep 16, 2023

happysalada commented Sep 16, 2023

acairncross commented Sep 16, 2023

happysalada commented Sep 16, 2023

happysalada commented Sep 16, 2023 • edited Loading

acairncross commented Sep 16, 2023

happysalada commented Sep 16, 2023

acairncross commented Sep 17, 2023

happysalada commented Sep 18, 2023

acairncross left a comment

Choose a reason for hiding this comment

happysalada commented Sep 18, 2023

happysalada commented Sep 18, 2023

happysalada commented Sep 18, 2023

happysalada commented Sep 18, 2023

happysalada commented Sep 14, 2023 •

edited

Loading

happysalada commented Sep 16, 2023 •

edited

Loading