-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matrix-synapse-tools.rust-synapse-compress-state: 0.1.3 -> 0.1.4 #303704
matrix-synapse-tools.rust-synapse-compress-state: 0.1.3 -> 0.1.4 #303704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Diff looks okay, package builds and executable seems to be working. Haven’t tested it on a real db, but issues there wouldn’t seem packaging related.
What’s the issue with the lock file? I have no clue of rust packaging best practices. That’s a lot of data to check-in. Is this the recommended way now? Is there a reason that the cargoHash solution does not work anymore?
Edit: I have been notified that the lock file is needed because a dependency is a git reference with missing hash.
I pinned the git reference dependency upstream, so the next version of the package won't need the Cargo lock hopefully. |
Thanks, though this sadly won't allow us to remove the Forbidding git deps without
succeeds as it will be fetched from
fails with
|
Well, thanks for reminding me of this PR. This has simmered long enough now. |
Description of changes
https://github.com/matrix-org/rust-synapse-compress-state/releases/tag/v0.1.4
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.