Reinstate not_followed_by and add to DecimalLiteral also remove _ in dsl keywords.
#575
Conversation
|
There was a problem hiding this comment.
I suggest checking the other places in the YAML grammar where we are using notFollowedBy. For example, I just checked MultilineComment, and because the new DSL doesn't use it, we fail to scan /* foo **/. I suggest adding a test for that in crates/solidity/outputs/cargo/tests/src/scanner/mod.rs.
AntonyBlakey
force-pushed
the
AntonyBlakey/revive-not_followed_by
branch
from
a585e35
to
f57ee26
Compare
I have added it to the other items that have it in the yaml. This raises some issues, although not a regression: |
AntonyBlakey
force-pushed
the
AntonyBlakey/revive-not_followed_by
branch
from
4dc5e20
to
ffed3f7
Compare
| }) | ||
| }}; | ||
| } | ||
|
|
||
| #[allow(unused_macros)] | ||
| macro_rules! scan_not_followed_by { | ||
| ($stream:ident, $scanner:expr, $not_followed_by:expr) => { |
There was a problem hiding this comment.
nit: I like how delimited by tokens improve legibility of the DSL, maybe changing it to
($stream:ident, $scanner:expr, not followed by: $not_followed_by:expr)
would improve legibility of scan_not_followed_by macro calls here?
| }) | ||
| }}; | ||
| } | ||
|
|
||
| #[allow(unused_macros)] |
There was a problem hiding this comment.
Is this allow still needed?
No description provided.