Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export PDF,JSON, CSV does not fully take into account the Marking Restriction #7348

Closed
nino-filigran opened this issue Jun 11, 2024 · 0 comments · Fixed by #7353
Closed

Export PDF,JSON, CSV does not fully take into account the Marking Restriction #7348

nino-filigran opened this issue Jun 11, 2024 · 0 comments · Fixed by #7353
Assignees
@Archidoit
Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 6.1.11

Comments

@nino-filigran
Copy link

nino-filigran commented Jun 11, 2024 •
edited
Loading

Description

When allowing a user with access to a TLP, without granting the user the user the ability to export any TLP, when performing an Export PDF/JSON/CSV of a report, some entities having TLP Green are still shared.

Environment

Testing

Reproducible Steps

  1. Have a group with user TLP = RED but Max shareable Marking = none
  2. Log in with this user
  3. Access a report TLP RED
  4. In this report, have some entities (including Indicators & observables generated from inference rule) TLP Green, entities without marking, and entities with higher marking than TLP Green
  5. Export PDF in Full
  6. The choice of the max marking to export should be none

Expected Output

Only entities without marking are in the export

Actual Output

TLP green & Clear entities are in the export

Additional information

I have all links available if needed, since it's been done on testing.

Screenshots (optional)

2024-06-11T14_14_10.446Z_TLP_ALL_(ExportReportPdf)_Report-test_full.pdf
2024-06-11T14_26_56.672Z_TLP_ALL_(ExportFileStix2)_Report-test_full (1).json
2024-06-11T14_33_05.819Z_TLP_ALL_(ExportFileCsv)_Report-test_full (1).csv
@nino-filigran nino-filigran added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team critical use to identify critical bug to fix ASAP and removed needs triage use to identify issue needing triage from Filigran Product team labels Jun 11, 2024
@nino-filigran nino-filigran changed the title Export PDF does not fully take into account the Marking Restriction Export PDF,JSON does not fully take into account the Marking Restriction Jun 11, 2024
@nino-filigran nino-filigran changed the title Export PDF,JSON does not fully take into account the Marking Restriction Export PDF,JSON, CSV does not fully take into account the Marking Restriction Jun 11, 2024
@Archidoit Archidoit self-assigned this Jun 11, 2024
@Archidoit Archidoit mentioned this issue Jun 12, 2024
Merged
@Archidoit Archidoit linked a pull request Jun 12, 2024 that will close this issue
[backend/frontend] Rework model for Max shareable (#7348) #7353
Merged
Archidoit added a commit that referenced this issue Jun 12, 2024
@Archidoit
[backend] renaming (#7348)
5df2531
Archidoit added a commit that referenced this issue Jun 12, 2024
@Archidoit
[frontend] fix removing of an allowed marking (#7348)
1b3312b
Archidoit added a commit that referenced this issue Jun 12, 2024
@Archidoit
[frontend] rename 'all' in 'no restrictions' (#7348)
179c8b7
Archidoit added a commit that referenced this issue Jun 12, 2024
@Archidoit
[backend] fix migration (#7348)
3350f61
Archidoit added a commit that referenced this issue Jun 12, 2024
@Archidoit
[backend] fix attribute declaration (#7348)
9126f39
Archidoit added a commit that referenced this issue Jun 12, 2024
@Archidoit
[backend] renaming (#7348)
f47a3e0
Archidoit added a commit that referenced this issue Jun 12, 2024
@Archidoit
[frontend] fix removing of an allowed marking (#7348)
9ea8ea7
Archidoit added a commit that referenced this issue Jun 12, 2024
@Archidoit
[frontend] rename 'all' in 'no restrictions' (#7348)
15c85ed
Archidoit added a commit that referenced this issue Jun 12, 2024
@Archidoit
[backend] fix migration (#7348)
a017520
Archidoit added a commit that referenced this issue Jun 12, 2024
@Archidoit
[backend] fix attribute declaration (#7348)
20847d0
Archidoit added a commit that referenced this issue Jun 12, 2024
@Archidoit @Kedae @lndrtrbn
[backend/frontend] Rework model for Max shareable markings (#7348)
ef515b0 
Co-authored-by: Adrien Servel <adrien.servel@filigran.io>
Co-authored-by: Landry Trebon <landry.trebon@filigran.io>
@Archidoit Archidoit added the solved use to identify issue that has been solved (must be linked to the solving PR) label Jun 12, 2024
aHenryJard pushed a commit that referenced this issue Jun 12, 2024
@Archidoit @Kedae
@lndrtrbn @aHenryJard
[backend/frontend] Rework model for Max shareable markings (#7348)
ba44da0 
Co-authored-by: Adrien Servel <adrien.servel@filigran.io>
Co-authored-by: Landry Trebon <landry.trebon@filigran.io>
Kedae added a commit that referenced this issue Jun 13, 2024
@Kedae
[frontend] Improve content marking usage (#7348) (#7364)
cdc007f
@SamuelHassine SamuelHassine added this to the Release 6.1.11 milestone Jun 13, 2024
daimyo007 pushed a commit to fbicyber/opencti__opencti that referenced this issue Jun 24, 2024
@Archidoit @Kedae
@lndrtrbn @daimyo007
[backend/frontend] Rework model for Max shareable markings (OpenCTI-P…
1eac78a 
…latform#7348)

Co-authored-by: Adrien Servel <adrien.servel@filigran.io>
Co-authored-by: Landry Trebon <landry.trebon@filigran.io>
daimyo007 pushed a commit to fbicyber/opencti__opencti that referenced this issue Jun 24, 2024
@Kedae @daimyo007
[frontend] Improve content marking usage (OpenCTI-Platform#7348) (Ope…
882d743 
…nCTI-Platform#7364)
Goumies pushed a commit that referenced this issue Jun 25, 2024
@Archidoit @Kedae
@lndrtrbn @Goumies
[backend/frontend] Rework model for Max shareable markings (#7348)
80bf464 
Co-authored-by: Adrien Servel <adrien.servel@filigran.io>
Co-authored-by: Landry Trebon <landry.trebon@filigran.io>
Goumies pushed a commit that referenced this issue Jun 25, 2024
@Kedae @Goumies
[frontend] Improve content marking usage (#7348) (#7364)
0b7f85e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Archidoit Archidoit

Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 6.1.11
Development

Successfully merging a pull request may close this issue.

[backend/frontend] Rework model for Max shareable (#7348) OpenCTI-Platform/opencti
3 participants
@SamuelHassine @Archidoit @nino-filigran