Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Add env var in local e2e run to sandbox all infra (#6704) #7002

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

aHenryJard
Copy link
Member

Proposed changes

  • Add env var to sandbox infra when running tests locally.
  • use same name as CI for elastic

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@aHenryJard aHenryJard changed the title Add env var in local e2e run to sandbox all infra (#6704) [e2e] Add env var in local e2e run to sandbox all infra (#6704) May 17, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.54%. Comparing base (e383348) to head (6f95377).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7002      +/-   ##
==========================================
- Coverage   67.54%   67.54%   -0.01%     
==========================================
  Files         561      561              
  Lines       68754    68754              
  Branches     5837     5836       -1     
==========================================
- Hits        46443    46438       -5     
- Misses      22311    22316       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard marked this pull request as ready for review May 27, 2024 08:30
@aHenryJard aHenryJard added the filigran team use to identify PR from the Filigran team label May 27, 2024
@aHenryJard aHenryJard merged commit 2eb5dfd into master Jun 4, 2024
5 checks passed
@SamuelHassine SamuelHassine deleted the issue/6704-run-test branch June 28, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants