Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] add content tab on all entities (#5651) #7011

Merged
merged 7 commits into from
May 28, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented May 17, 2024

Proposed changes

  • add content tab on all entities
  • refacto => stixDomainObjectContent to stixCoreObjectContent

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@marieflorescontact marieflorescontact added the filigran team use to identify PR from the Filigran team label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.48%. Comparing base (ee1e281) to head (4ab94b0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7011   +/-   ##
=======================================
  Coverage   67.48%   67.48%           
=======================================
  Files         561      561           
  Lines       68734    68734           
  Branches     5775     5775           
=======================================
  Hits        46384    46384           
  Misses      22350    22350           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyCloarec JeremyCloarec force-pushed the issue/5651-chunk1 branch 2 times, most recently from 15da192 to 6c2d689 Compare May 22, 2024 13:08
@marieflorescontact marieflorescontact marked this pull request as ready for review May 22, 2024 14:33
@@ -1678,6 +1678,7 @@
"Observable types": "Tipos de observable",
"Observable value": "Valor del observable",
"observable(s)": "observable(s)",
"observableName": "Nombre",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: is it intended to have some time first letter with upper case and sometime no in translations ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point thnkas, that's an error, they should all be lower case

Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally it's good for me. Be carefull with the PR title before merge, it's missing the issue number.

@JeremyCloarec JeremyCloarec changed the title Issue/5651 chunk1: add content tab on all entities [frontend] add content tab on all entities (#5651) May 28, 2024
@marieflorescontact marieflorescontact merged commit 24dfc1d into master May 28, 2024
5 checks passed
@marieflorescontact marieflorescontact deleted the issue/5651-chunk1 branch May 28, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants