-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] add content tab on all entities (#5651) #7011
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7011 +/- ##
=======================================
Coverage 67.48% 67.48%
=======================================
Files 561 561
Lines 68734 68734
Branches 5775 5775
=======================================
Hits 46384 46384
Misses 22350 22350 ☔ View full report in Codecov by Sentry. |
15da192
to
6c2d689
Compare
fedb5b2
to
4ab94b0
Compare
@@ -1678,6 +1678,7 @@ | |||
"Observable types": "Tipos de observable", | |||
"Observable value": "Valor del observable", | |||
"observable(s)": "observable(s)", | |||
"observableName": "Nombre", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: is it intended to have some time first letter with upper case and sometime no in translations ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point thnkas, that's an error, they should all be lower case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally it's good for me. Be carefull with the PR title before merge, it's missing the issue number.
Proposed changes
stixDomainObjectContent
tostixCoreObjectContent
Related issues
Checklist
Further comments