Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Add available filter keys to stored filters for Taxii collections #7057

Merged
merged 7 commits into from
May 23, 2024

Conversation

Goumies
Copy link
Member

@Goumies Goumies commented May 21, 2024

Closes #5844

Proposed changes

  • Add available filter keys from the backend for Data sharing > Taxii collections (chunk# 1)
  • Test custom hook
  • Test query

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@Goumies Goumies marked this pull request as ready for review May 21, 2024 18:12
@Goumies Goumies requested review from Archidoit and jpkha May 21, 2024 18:12
@Archidoit

This comment was marked as resolved.

@Goumies Goumies changed the title Issue/5844 [frontend/backend] Add available filter keys to stored filters for Taxii collections May 22, 2024
@Goumies Goumies added the filigran team use to identify PR from the Filigran team label May 22, 2024
@Goumies Goumies requested a review from Archidoit May 22, 2024 10:18
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.46%. Comparing base (09d82e1) to head (6793eea).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7057   +/-   ##
=======================================
  Coverage   67.46%   67.46%           
=======================================
  Files         561      561           
  Lines       68698    68698           
  Branches     5762     5763    +1     
=======================================
+ Hits        46349    46350    +1     
+ Misses      22349    22348    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Goumies Goumies merged commit d89c48a into master May 23, 2024
5 checks passed
Archidoit pushed a commit that referenced this pull request Jun 6, 2024
Goumies added a commit that referenced this pull request Jun 25, 2024
@SamuelHassine SamuelHassine deleted the issue/5844 branch June 28, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filter "pattern" for Indicator in Stored Filters (Data sharing, etc.) with the operator starts with
2 participants