[frontend] Add content mapping in content tab (#5651) #7136

marieflorescontact · 2024-05-27T14:41:34Z

remove content mapping from knowledge Tab for container
add content mapping in content Tab for Grouping/Report/Cases
add root component to switch from content to content mapping in Tab content

Related issues

issue/5651

Checklist

I consider the submitted work as finished
I tested the code for its functionality
I wrote test cases for the relevant uses case (coverage and e2e)
I added/update the relevant documentation (either on github or on notion)
Where necessary I refactored code to improve the overall quality

Further comments

codecov · 2024-05-30T05:53:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.21%. Comparing base (08932ab) to head (65fa491).
Report is 8 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7136      +/-   ##
==========================================
+ Coverage   67.75%   68.21%   +0.45%     
==========================================
  Files         561      561              
  Lines       68824    68891      +67     
  Branches     5871     6460     +589     
==========================================
+ Hits        46631    46992     +361     
+ Misses      22193    21899     -294

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

opencti-platform/opencti-front/src/private/components/analyses/malware_analyses/Root.tsx

opencti-platform/opencti-front/src/private/components/arsenal/malwares/Root.jsx

.../opencti-front/src/private/components/common/stix_core_objects/StixCoreObjectContentRoot.tsx

SouadHadjiat · 2024-05-30T13:32:43Z

Description seem to be always empty in content mapping view (tested for serveral reports)

Even content is empty, when trying to create a report with a content, and selecting "create and map", the content mapping view displays empty content.

marieflorescontact · 2024-05-31T14:22:07Z

Description seem to be always empty in content mapping view (tested for serveral reports)

Fixed

marieflorescontact · 2024-05-31T15:31:40Z

all comments have been taken into account, ready for another review

SouadHadjiat · 2024-06-06T10:06:55Z

opencti-platform/opencti-front/src/utils/utils.ts

+  return location.pathname;
+};
+
+export const getPaddingRight = (location: Location, entity_id: string, entity_type_path: string) => {


Thanks for refactoring this part: just one small question: since we only use location.pathname, I don't see the use to have the whole Location object in parameter, maybe locationPath is enough ? same question for getCurrentTab.

SouadHadjiat · 2024-06-06T12:38:21Z

I'm wondering about the icon used in content for content view which is the same as for graph view, but we only display the content (content & files), shouldn't we use another icon?

marieflorescontact · 2024-06-06T12:49:02Z

I'm wondering about the icon used in content for content view which is the same as for graph view, but we only display the content (content & files), shouldn't we use another icon?

yes we should definitly use another icon :) @nino-filigran

nino-filigran · 2024-06-06T12:54:09Z

Can't we use a toggle? Since the action is more to "enable/disable" a mode @marieflorescontact

marieflorescontact · 2024-06-06T13:54:57Z

Can't we use a toggle? Since the action is more to "enable/disable" a mode @marieflorescontact

as discussed with @nino-filigran we will use :

marieflorescontact · 2024-06-06T13:55:31Z

all comments have been taken into account, ready for another review

SouadHadjiat · 2024-06-07T14:03:25Z

Content mapping view works all right ✅

However there seem to be a padding issue here :

SouadHadjiat · 2024-06-10T08:42:58Z

There is an issue now in reports -> knowledge, the graph should take the whole width :

… methods

marieflorescontact · 2024-06-11T14:20:04Z

There is an issue now in reports -> knowledge, the graph should take the whole width :

fixed

marieflorescontact · 2024-06-11T14:20:32Z

all comments have been taken into account, ready for another review

SouadHadjiat · 2024-06-11T15:07:08Z

SouadHadjiat · 2024-06-11T15:47:21Z

"knowledge" tab is not selected here in threat actor group

SouadHadjiat · 2024-06-12T12:27:05Z

Feedback has a content mapping button :

And infrastructure doesn't have "knowledge" current tab selected:

marieflorescontact · 2024-06-12T13:05:53Z

all comments have been taken into account, ready for another review

SouadHadjiat · 2024-06-12T15:02:46Z

just found another one with wrong padding:

But it's actually already like this in production, so not a regression of this PR

marieflorescontact force-pushed the issue/5651-chunk2 branch 2 times, most recently from a6492b1 to 8a9cf76 Compare May 29, 2024 12:40

JeremyCloarec force-pushed the issue/5651-chunk2 branch from 3c4edf4 to c90e5a8 Compare May 29, 2024 14:42

marieflorescontact changed the title ~~[frontend] Add StixCoreObjectContentHeader and StixCoreObjectContentR…~~ [frontend] Add content mapping in content tab (#5651) May 29, 2024

marieflorescontact marked this pull request as ready for review May 29, 2024 14:46

marieflorescontact force-pushed the issue/5651-chunk2 branch from c90e5a8 to 8f64cf0 Compare May 29, 2024 15:16

SamuelHassine force-pushed the master branch from 8d9d934 to 163cc38 Compare May 29, 2024 15:28

marieflorescontact force-pushed the issue/5651-chunk2 branch 2 times, most recently from d4cdccf to f2c84b3 Compare May 30, 2024 05:24

SouadHadjiat reviewed May 30, 2024

View reviewed changes

opencti-platform/opencti-front/src/private/components/analyses/malware_analyses/Root.tsx Outdated Show resolved Hide resolved

SouadHadjiat reviewed May 30, 2024

View reviewed changes

opencti-platform/opencti-front/src/private/components/arsenal/malwares/Root.jsx Outdated Show resolved Hide resolved

SouadHadjiat reviewed May 30, 2024

View reviewed changes

.../opencti-front/src/private/components/common/stix_core_objects/StixCoreObjectContentRoot.tsx Show resolved Hide resolved

marieflorescontact force-pushed the issue/5651-chunk2 branch 2 times, most recently from 148739e to 0d2597f Compare May 31, 2024 12:21

marieflorescontact force-pushed the issue/5651-chunk2 branch from 65a83cc to f4a6c4f Compare May 31, 2024 14:40

marieflorescontact requested a review from SouadHadjiat June 5, 2024 06:28

marieflorescontact force-pushed the issue/5651-chunk2 branch from f4a6c4f to d62a5a7 Compare June 5, 2024 13:07

JeremyCloarec added the filigran team use to identify PR from the Filigran team label Jun 6, 2024

SouadHadjiat reviewed Jun 6, 2024

View reviewed changes

marieflorescontact force-pushed the issue/5651-chunk2 branch from d62a5a7 to ff0ccf5 Compare June 6, 2024 10:12

marieflorescontact force-pushed the issue/5651-chunk2 branch from 4bd27c0 to 49a620b Compare June 7, 2024 12:52

marieflorescontact self-assigned this Jun 11, 2024

marieflorescontact and others added 6 commits June 11, 2024 15:53

[frontend] Add content mapping in content tab (#5651)

a8d2d01

[frontend] review

689cde7

[frontend] review: use location.pathname instead of location in utils…

a5b4cbc

… methods

[frontend] review: change icon

d90da9a

[frontend] added feature flag

53873f0

[frontend] added knowledge page padding in getPaddingRight

5786db1

marieflorescontact force-pushed the issue/5651-chunk2 branch from 06ff673 to 5786db1 Compare June 11, 2024 13:55

[frontend] review

cf63b6b

[frontend] changed padding for some knowledge tabs

88f434a

[frontend] review

104be25

[frontend] review

2b1b3f0

SouadHadjiat approved these changes Jun 12, 2024

View reviewed changes

[frontend] review

65fa491

marieflorescontact merged commit e364f82 into master Jun 13, 2024
5 checks passed

marieflorescontact deleted the issue/5651-chunk2 branch June 13, 2024 14:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[frontend] Add content mapping in content tab (#5651) #7136

[frontend] Add content mapping in content tab (#5651) #7136

marieflorescontact commented May 27, 2024 •

edited

Loading

codecov bot commented May 30, 2024 •

edited

Loading

SouadHadjiat commented May 30, 2024 •

edited

Loading

marieflorescontact commented May 31, 2024 •

edited

Loading

marieflorescontact commented May 31, 2024

SouadHadjiat Jun 6, 2024

SouadHadjiat commented Jun 6, 2024

marieflorescontact commented Jun 6, 2024

nino-filigran commented Jun 6, 2024

marieflorescontact commented Jun 6, 2024

marieflorescontact commented Jun 6, 2024

SouadHadjiat commented Jun 7, 2024 •

edited

Loading

SouadHadjiat commented Jun 10, 2024

marieflorescontact commented Jun 11, 2024

marieflorescontact commented Jun 11, 2024

SouadHadjiat commented Jun 11, 2024

SouadHadjiat commented Jun 11, 2024

SouadHadjiat commented Jun 12, 2024

marieflorescontact commented Jun 12, 2024

SouadHadjiat commented Jun 12, 2024 •

edited

Loading

[frontend] Add content mapping in content tab (#5651) #7136

[frontend] Add content mapping in content tab (#5651) #7136

Conversation

marieflorescontact commented May 27, 2024 • edited Loading

Related issues

Checklist

Further comments

codecov bot commented May 30, 2024 • edited Loading

Codecov Report

SouadHadjiat commented May 30, 2024 • edited Loading

marieflorescontact commented May 31, 2024 • edited Loading

marieflorescontact commented May 31, 2024

SouadHadjiat Jun 6, 2024

Choose a reason for hiding this comment

SouadHadjiat commented Jun 6, 2024

marieflorescontact commented Jun 6, 2024

nino-filigran commented Jun 6, 2024

marieflorescontact commented Jun 6, 2024

marieflorescontact commented Jun 6, 2024

SouadHadjiat commented Jun 7, 2024 • edited Loading

SouadHadjiat commented Jun 10, 2024

marieflorescontact commented Jun 11, 2024

marieflorescontact commented Jun 11, 2024

SouadHadjiat commented Jun 11, 2024

SouadHadjiat commented Jun 11, 2024

SouadHadjiat commented Jun 12, 2024

marieflorescontact commented Jun 12, 2024

SouadHadjiat commented Jun 12, 2024 • edited Loading

marieflorescontact commented May 27, 2024 •

edited

Loading

codecov bot commented May 30, 2024 •

edited

Loading

SouadHadjiat commented May 30, 2024 •

edited

Loading

marieflorescontact commented May 31, 2024 •

edited

Loading

SouadHadjiat commented Jun 7, 2024 •

edited

Loading

SouadHadjiat commented Jun 12, 2024 •

edited

Loading