Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] show effective max confidence with creators (#6878) #7186

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

labo-flg
Copy link
Member

@labo-flg labo-flg commented May 30, 2024

Proposed changes

  • update creators API to be able to query effective_confidence_level in case of user creator, or group_confidence_level in case of group creator
  • update CreatorField to show the confidence level of the user in the Autocomplete box

Related issues

#6878

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

image

Comment on lines +1334 to +1337
# entity_type == User
effective_confidence_level: EffectiveConfidenceLevel
# entity_type == Group
group_confidence_level: ConfidenceLevel
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFC here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the resolver for this field ? I see only effective_confidence_level resolver for Member.

Copy link
Member Author

@labo-flg labo-flg Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field does not need specific resolution. We pull the entities from elastic and group_confidence_level is one of the field returned in case it's a group.

on the contrary effective_confidence_level is a computed field, not stored in elastic.

Copy link
Member

@SouadHadjiat SouadHadjiat Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need it somewhere group_confidence_level ? I can't find where we use it in the frontend calling members API.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, group_confidence_level is unused for now but I added in anticipation.

@labo-flg labo-flg force-pushed the issue/6878-confidence-creator branch from ffb7567 to 0b3068d Compare May 30, 2024 12:43
@labo-flg labo-flg self-assigned this May 30, 2024
@labo-flg labo-flg added the filigran team use to identify PR from the Filigran team label May 30, 2024
@labo-flg labo-flg marked this pull request as ready for review May 30, 2024 12:45
@labo-flg labo-flg marked this pull request as draft May 30, 2024 15:03
@labo-flg
Copy link
Member Author

back to draft : need improvements to link to user's details

@labo-flg labo-flg marked this pull request as ready for review May 30, 2024 15:49
@labo-flg labo-flg force-pushed the issue/6878-confidence-creator branch from cb692bb to 17a2309 Compare May 31, 2024 07:09
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.57%. Comparing base (7cea4ce) to head (835ef7c).
Report is 4 commits behind head on master.

Files Patch % Lines
...cti-platform/opencti-graphql/src/resolvers/user.js 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7186      +/-   ##
==========================================
+ Coverage   67.55%   67.57%   +0.01%     
==========================================
  Files         561      561              
  Lines       68760    68766       +6     
  Branches     5833     5836       +3     
==========================================
+ Hits        46454    46468      +14     
+ Misses      22306    22298       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lndrtrbn lndrtrbn self-requested a review May 31, 2024 08:02
@labo-flg labo-flg force-pushed the issue/6878-confidence-creator branch from 17a2309 to 7a5cd19 Compare June 3, 2024 09:03
@labo-flg labo-flg force-pushed the issue/6878-confidence-creator branch from 5fbef09 to 835ef7c Compare June 3, 2024 09:10
@labo-flg labo-flg merged commit 06c6efe into master Jun 10, 2024
5 checks passed
@labo-flg labo-flg deleted the issue/6878-confidence-creator branch June 10, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants