-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend/backend] show effective max confidence with creators (#6878) #7186
Conversation
opencti-platform/opencti-front/src/private/components/common/form/CreatorField.tsx
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/common/form/CreatorField.tsx
Show resolved
Hide resolved
...cti-platform/opencti-front/src/private/components/data/ingestionCsv/IngestionCsvCreation.tsx
Show resolved
Hide resolved
# entity_type == User | ||
effective_confidence_level: EffectiveConfidenceLevel | ||
# entity_type == Group | ||
group_confidence_level: ConfidenceLevel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RFC here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is the resolver for this field ? I see only effective_confidence_level resolver for Member.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this field does not need specific resolution. We pull the entities from elastic and group_confidence_level
is one of the field returned in case it's a group.
on the contrary effective_confidence_level
is a computed field, not stored in elastic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need it somewhere group_confidence_level
? I can't find where we use it in the frontend calling members API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed, group_confidence_level
is unused for now but I added in anticipation.
ffb7567
to
0b3068d
Compare
back to draft : need improvements to link to user's details |
cb692bb
to
17a2309
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7186 +/- ##
==========================================
+ Coverage 67.55% 67.57% +0.01%
==========================================
Files 561 561
Lines 68760 68766 +6
Branches 5833 5836 +3
==========================================
+ Hits 46454 46468 +14
+ Misses 22306 22298 -8 ☔ View full report in Codecov by Sentry. |
opencti-platform/opencti-front/src/private/components/common/form/CreatorField.tsx
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/common/form/CreatorField.tsx
Outdated
Show resolved
Hide resolved
17a2309
to
7a5cd19
Compare
opencti-platform/opencti-front/src/private/components/common/form/CreatorField.tsx
Show resolved
Hide resolved
5fbef09
to
835ef7c
Compare
Proposed changes
creators
API to be able to queryeffective_confidence_level
in case of user creator, orgroup_confidence_level
in case of group creatorRelated issues
#6878
Checklist