Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] modify EntityStixCoreRelationshipsEntitiesComponent to list entities through relations #7249

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Jun 6, 2024

Proposed changes

  • add new stixCoreObjectsRegardingOf query
  • stixCoreObjectsRegardingOf uses listEntitiesThroughRelationsPaginated to return the list of asked entities checking relationships markings
  • modified listEntitiesThroughRelationsPaginated to handle queries asking for relations on both directions

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@JeremyCloarec JeremyCloarec added the filigran team use to identify PR from the Filigran team label Jun 6, 2024
@JeremyCloarec JeremyCloarec marked this pull request as draft June 6, 2024 09:27
@JeremyCloarec JeremyCloarec marked this pull request as ready for review June 6, 2024 10:54
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 48.27586% with 75 lines in your changes missing coverage. Please review.

Project coverage is 67.73%. Comparing base (e364f82) to head (c5a4ed1).
Report is 1 commits behind head on master.

Files Patch % Lines
.../opencti-graphql/src/database/middleware-loader.ts 57.50% 34 Missing ⚠️
...tform/opencti-graphql/src/domain/stixCoreObject.js 14.28% 18 Missing ⚠️
...atform/opencti-graphql/src/domain/attackPattern.ts 25.00% 3 Missing ⚠️
...ncti-platform/opencti-graphql/src/domain/region.js 50.00% 2 Missing ⚠️
...platform/opencti-graphql/src/domain/threatActor.js 0.00% 2 Missing ⚠️
.../modules/malwareAnalysis/malwareAnalysis-domain.ts 0.00% 2 Missing ⚠️
...-graphql/src/modules/narrative/narrative-domain.ts 0.00% 2 Missing ⚠️
...ql/src/modules/organization/organization-domain.ts 50.00% 2 Missing ⚠️
...rm/opencti-graphql/src/modules/task/task-domain.ts 0.00% 2 Missing ⚠️
...encti-platform/opencti-graphql/src/domain/group.js 50.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7249   +/-   ##
=======================================
  Coverage   67.72%   67.73%           
=======================================
  Files         561      561           
  Lines       68980    69059   +79     
  Branches     5874     5911   +37     
=======================================
+ Hits        46718    46776   +58     
- Misses      22262    22283   +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SarahBocognano SarahBocognano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅
Code review with Jeremy ✅

@JeremyCloarec JeremyCloarec merged commit 2019c63 into master Jun 17, 2024
5 checks passed
@JeremyCloarec JeremyCloarec deleted the issue/6867 branch June 17, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants