Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Ask AI button in Ask AI dialog is semi-hidden (#6829) #7404

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

ValentinBouzinFiligran
Copy link
Member

@ValentinBouzinFiligran ValentinBouzinFiligran commented Jun 18, 2024

Proposed changes

  • small padding-top on dialog content to show correctly the AI button

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

before :
image

after :
image

@ValentinBouzinFiligran ValentinBouzinFiligran added the filigran team use to identify PR from the Filigran team label Jun 18, 2024
@ValentinBouzinFiligran ValentinBouzinFiligran linked an issue Jun 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.60%. Comparing base (98165c6) to head (359b7f5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7404   +/-   ##
=======================================
  Coverage   67.59%   67.60%           
=======================================
  Files         561      561           
  Lines       69190    69190           
  Branches     5880     5881    +1     
=======================================
+ Hits        46770    46776    +6     
+ Misses      22420    22414    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ValentinBouzinFiligran ValentinBouzinFiligran merged commit cb75aec into master Jun 18, 2024
5 checks passed
@ValentinBouzinFiligran ValentinBouzinFiligran deleted the issue/6829 branch June 18, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask AI button in Ask AI dialog is semi-hidden
2 participants