Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] simple stix object relationship fragment update (#6865) #7472

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

ValentinBouzinFiligran
Copy link
Member

@ValentinBouzinFiligran ValentinBouzinFiligran commented Jun 25, 2024

Proposed changes

  • Simple stix object relationship fragment updated to show from and to value
    • from and to added on fragment

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@ValentinBouzinFiligran ValentinBouzinFiligran added the filigran team use to identify PR from the Filigran team label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.56%. Comparing base (3355b5f) to head (1cad15d).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7472   +/-   ##
=======================================
  Coverage   67.55%   67.56%           
=======================================
  Files         567      567           
  Lines       69903    69903           
  Branches     5936     5937    +1     
=======================================
+ Hits        47223    47228    +5     
+ Misses      22680    22675    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit
Copy link
Member

you should rather use 'representative' in the query to avoid this long list for each entity type
(see toolBarContainersQuery for instance)

@ValentinBouzinFiligran ValentinBouzinFiligran marked this pull request as draft June 28, 2024 08:03
@ValentinBouzinFiligran
Copy link
Member Author

From data/Relationships
image

With Linked entities
image

On relationship view
image

@ValentinBouzinFiligran ValentinBouzinFiligran marked this pull request as ready for review July 1, 2024 08:18
@labo-flg
Copy link
Member

labo-flg commented Jul 1, 2024

Tested OK ✅

@ValentinBouzinFiligran ValentinBouzinFiligran merged commit 6e7759a into master Jul 3, 2024
5 checks passed
@ValentinBouzinFiligran ValentinBouzinFiligran deleted the issue/6865 branch July 3, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last created relationship with a relationship displayed as Unknown
4 participants