Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix [Bulk search] Sorting on the columns doesn't work (#7215) #7513

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

SarahBocognano
Copy link
Member

Proposed changes

  • Adapt the reversedBy function
  • Change resolvedStixCoreObjects field "containersNumber.total" to "analyses" for the sort to be taken into account.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Jun 28, 2024
@SarahBocognano SarahBocognano self-assigned this Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.56%. Comparing base (d401814) to head (f9adb79).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7513   +/-   ##
=======================================
  Coverage   67.55%   67.56%           
=======================================
  Files         567      567           
  Lines       69903    69903           
  Branches     5937     5937           
=======================================
+ Hits        47226    47231    +5     
+ Misses      22677    22672    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit
Copy link
Member

Nothing to do with sorting, but can you fix this in your PR : when no author, a '-' should be displayed instead of nothing (like for creation date)
image

@Archidoit
Copy link
Member

Nothing is displayed in the 'creation date' column whereas entities have a creation date
image

@Archidoit
Copy link
Member

When you pass the mouse on the 'label' column title, the mouse should be a pointer and not a 'clickable' hand icon. (see exemple when the mouse hovers the label column title in the reports list)

@SarahBocognano
Copy link
Member Author

Update: Comments fixed

@Archidoit
Copy link
Member

Everything is ok 👍 just waiting for the tests to pass

@SarahBocognano SarahBocognano merged commit 7b1f42b into master Jul 2, 2024
5 checks passed
@SarahBocognano SarahBocognano deleted the issue/7215 branch July 2, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants