Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] score bulk update only authorized on entity types with score (#6870) #7549

Merged
merged 1 commit into from
Jul 2, 2024
Merged

[frontend] score bulk update only authorized on entity types with score (#6870) #7549

merged 1 commit into from
Jul 2, 2024

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Jul 1, 2024 •
edited
Loading

PR content:

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Jul 1, 2024
@Archidoit Archidoit self-assigned this Jul 1, 2024
@Archidoit Archidoit linked an issue Jul 1, 2024 that may be closed by this pull request
Bulk update allow irrelevant actions #6870
Closed
SarahBocognano
SarahBocognano approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@SarahBocognano SarahBocognano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice for the refacto and removing ramda ! Tested ✅

@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.56%. Comparing base (d401814) to head (a2e8808).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #7549   +/-   ##
=======================================
  Coverage   67.55%   67.56%           
=======================================
  Files         567      567           
  Lines       69903    69903           
  Branches     5937     5938    +1     
=======================================
+ Hits        47226    47228    +2     
+ Misses      22677    22675    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit Archidoit merged commit f24e329 into master Jul 2, 2024
5 checks passed
@Archidoit Archidoit deleted the issue/6870 branch July 2, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahBocognano SarahBocognano SarahBocognano approved these changes

Assignees

@Archidoit Archidoit

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bulk update allow irrelevant actions
2 participants
@Archidoit @SarahBocognano