Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix toggle shift and Loader (#5405) #7595

Merged
merged 3 commits into from
Jul 5, 2024
Merged

[frontend] Fix toggle shift and Loader (#5405) #7595

merged 3 commits into from
Jul 5, 2024

Conversation

Kedae
Copy link
Member

@Kedae Kedae commented Jul 4, 2024

Solve issues and closes #7591

@Kedae Kedae added the filigran team use to identify PR from the Filigran team label Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.56%. Comparing base (6ebcad3) to head (ae6c3a4).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7595   +/-   ##
=======================================
  Coverage   67.56%   67.56%           
=======================================
  Files         567      567           
  Lines       69946    69946           
  Branches     5936     5937    +1     
=======================================
  Hits        47256    47256           
  Misses      22690    22690           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg labo-flg self-requested a review July 4, 2024 14:34
Copy link
Member

@labo-flg labo-flg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK, minor comments, take it or leave it :)

Kedae and others added 2 commits July 5, 2024 08:48
Co-authored-by: Laurent Bonnet <146674147+labo-flg@users.noreply.github.com>
Co-authored-by: Laurent Bonnet <146674147+labo-flg@users.noreply.github.com>
@Kedae Kedae merged commit 9709e0c into master Jul 5, 2024
5 checks passed
@Kedae Kedae deleted the issue/5405 branch July 5, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The new loader should not be used at it is not ready
2 participants