Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[backend/frontend] modify EntityStixCoreRelationshipsEntitiesComponent to list entities through relations (#6867)" #7641

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

SouadHadjiat
Copy link
Member

This reverts commit 2019c63.

It was causing this issue #7625 and was breaking the toolbar (which had no more filters)

…Component to list entities through relations (#6867)"

This reverts commit 2019c63.
@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Jul 8, 2024
@SouadHadjiat SouadHadjiat marked this pull request as ready for review July 8, 2024 17:26
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 53.52113% with 33 lines in your changes missing coverage. Please review.

Project coverage is 67.59%. Comparing base (1b688ec) to head (105d648).

Files Patch % Lines
...tform/opencti-graphql/src/domain/stixCoreObject.js 12.50% 7 Missing ⚠️
...atform/opencti-graphql/src/domain/attackPattern.ts 25.00% 3 Missing ⚠️
.../opencti-graphql/src/domain/stixCyberObservable.js 0.00% 3 Missing ⚠️
...ncti-platform/opencti-graphql/src/domain/region.js 50.00% 2 Missing ⚠️
...platform/opencti-graphql/src/domain/threatActor.js 0.00% 2 Missing ⚠️
.../modules/malwareAnalysis/malwareAnalysis-domain.ts 0.00% 2 Missing ⚠️
...-graphql/src/modules/narrative/narrative-domain.ts 0.00% 2 Missing ⚠️
...ql/src/modules/organization/organization-domain.ts 50.00% 2 Missing ⚠️
...rm/opencti-graphql/src/modules/task/task-domain.ts 0.00% 2 Missing ⚠️
...encti-platform/opencti-graphql/src/domain/group.js 50.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7641      +/-   ##
==========================================
+ Coverage   67.54%   67.59%   +0.05%     
==========================================
  Files         567      567              
  Lines       69955    69881      -74     
  Branches     5935     5932       -3     
==========================================
- Hits        47251    47238      -13     
+ Misses      22704    22643      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aHenryJard aHenryJard self-requested a review July 9, 2024 07:27
@SouadHadjiat SouadHadjiat merged commit b6f7240 into master Jul 9, 2024
5 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/7625-revert-pr7249 branch July 9, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Export] Error when exporting "all selected" related entities of an entity
2 participants