Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix alignment of loader in knowledge graph(#7532) #7663

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

CelineSebe
Copy link
Member

Proposed changes

  • change boolean props

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@CelineSebe CelineSebe linked an issue Jul 10, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.61%. Comparing base (6289b3d) to head (561f971).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7663      +/-   ##
==========================================
+ Coverage   67.59%   67.61%   +0.02%     
==========================================
  Files         567      567              
  Lines       69883    69883              
  Branches     5929     5932       +3     
==========================================
+ Hits        47235    47250      +15     
+ Misses      22648    22633      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CelineSebe CelineSebe self-assigned this Jul 10, 2024
@CelineSebe CelineSebe added the filigran team use to identify PR from the Filigran team label Jul 10, 2024
@SamuelHassine SamuelHassine merged commit 091e795 into master Jul 10, 2024
5 checks passed
@SamuelHassine SamuelHassine deleted the issue/7532 branch July 10, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad alignement in knowledge graph loader
2 participants