Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left Nav Menu Changes #8137

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

Bonsai8863
Copy link
Contributor

Proposed changes

  • Made top-level left-nav text bolder to 600 weight
  • Boosted opacity value for selected items
  • Default submenu_show_icon to false

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

E2E automated tests are not necessary for a style change such as this.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.20%. Comparing base (e4d0be2) to head (93924bc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8137      +/-   ##
==========================================
- Coverage   66.21%   66.20%   -0.01%     
==========================================
  Files         597      597              
  Lines       60422    60422              
  Branches     6204     6203       -1     
==========================================
- Hits        40008    40005       -3     
- Misses      20414    20417       +3     
Flag Coverage Δ
66.20% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bonsai8863 Bonsai8863 force-pushed the left_nav_weights branch 2 times, most recently from 9e99108 to 071cbf7 Compare August 21, 2024 19:03
@Bonsai8863 Bonsai8863 force-pushed the left_nav_weights branch 3 times, most recently from 543bb0d to 627c786 Compare September 10, 2024 12:40
@Jipegien Jipegien added the community use to identify PR from community label Sep 12, 2024
@Bonsai8863 Bonsai8863 force-pushed the left_nav_weights branch 3 times, most recently from 3466f15 to cce4a81 Compare September 17, 2024 12:52
@Bonsai8863 Bonsai8863 force-pushed the left_nav_weights branch 4 times, most recently from 9d07450 to 4757192 Compare September 23, 2024 12:32
@Kedae Kedae merged commit d507f71 into OpenCTI-Platform:master Sep 24, 2024
5 checks passed
@Kedae Kedae deleted the left_nav_weights branch September 24, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants