Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] store enum filters values in constants #8436

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Sep 20, 2024

Proposed changes

Enum filters values where hardwritten in registration attributes files.
Now we refer to constants to avoid missing values in filters, as it was the case in #8414

Related issues

avoid issues like #8414

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Sep 20, 2024
@Archidoit Archidoit self-assigned this Sep 20, 2024
@Archidoit Archidoit added the technical improvement Technical refactor or improvement is needed label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.22%. Comparing base (8c63041) to head (8423534).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
...opencti-graphql/src/manager/notificationManager.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8436      +/-   ##
==========================================
+ Coverage   66.21%   66.22%   +0.01%     
==========================================
  Files         597      597              
  Lines       60422    60438      +16     
  Branches     6204     6205       +1     
==========================================
+ Hits        40008    40027      +19     
+ Misses      20414    20411       -3     
Flag Coverage Δ
66.22% <93.93%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit Archidoit merged commit a27b344 into master Sep 30, 2024
6 checks passed
@Archidoit Archidoit deleted the issue/enum branch September 30, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team technical improvement Technical refactor or improvement is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants