Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it impossible to action Tasks that don't have status 'waiting' or 'error' #138

Closed
dotsdl opened this issue May 4, 2023 · 0 comments · Fixed by #162
Closed

Make it impossible to action Tasks that don't have status 'waiting' or 'error' #138

dotsdl opened this issue May 4, 2023 · 0 comments · Fixed by #162

Comments

@dotsdl
Copy link
Member

dotsdl commented May 4, 2023

It looks like it's currently possible to action Tasks that are any status. We don't want this to be possible, as only Tasks that can conceivably be run yet (status is 'waiting' or 'error'). It shouldn't impact downstream compute, but does create unnecessary ACTIONS relationships to a TaskHub that will likely never be cleared.

We should add a status check in the Cypher query for Tasks actioned in Neo4jStore.action_tasks. We will return None for any Task that was requested to be actioned but ultimately was not; this should be the resulting behavior with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant