Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only action Tasks that are status 'waiting', 'error', or 'running' #162

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented Aug 8, 2023

Closes #138.

We also include 'running' as a valid status for actioning Tasks, as a currently 'running' Task may end up returning to either 'waiting' or becoming status 'error'. In other words, a user may reasonably want to action any non-complete/deleted/invalid Task on a given AlchemicalNetwork featuring that Task's Transformation.

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (26c845f) 81.97% compared to head (ec0cb08) 81.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files          21       21           
  Lines        2679     2679           
=======================================
  Hits         2196     2196           
  Misses        483      483           
Files Changed Coverage Δ
alchemiscale/interface/client.py 90.80% <ø> (ø)
alchemiscale/storage/statestore.py 93.97% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dotsdl dotsdl requested a review from hmacdope August 8, 2023 03:20
Copy link
Collaborator

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dotsdl dotsdl merged commit ea8d802 into main Aug 8, 2023
4 checks passed
@dotsdl dotsdl deleted the bugfix/issue-138 branch August 8, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it impossible to action Tasks that don't have status 'waiting' or 'error'
3 participants