-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Neo4j 5.x #242
Support Neo4j 5.x #242
Conversation
At this stage a full replacement of the subgraph class makes things too complicated. Instead, we'll make new functions take in subgraphs as arguments and operate on those at a lower level.
More spot fixes
To get this working, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
+ Coverage 81.69% 81.77% +0.07%
==========================================
Files 25 25
Lines 3049 3040 -9
==========================================
- Hits 2491 2486 -5
+ Misses 558 554 -4 ☔ View full report in Codecov by Sentry. |
This is ready for review after #235 is merged and we rebase this branch against |
@ianmkenney reviewing now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one edit needed given changes in #235. Otherwise looks great @ianmkenney!
Co-authored-by: David L. Dotson <dotsdl@gmail.com>
This PR allows to use of Neo4j 5.x with
alchemiscale
.