Adding bulk task creation server side #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous `create_task` method wraps around this new method and preserves previous functionality.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
- Coverage 82.28% 82.22% -0.07%
==========================================
Files 26 26
Lines 3066 3122 +56
==========================================
+ Hits 2523 2567 +44
- Misses 543 555 +12 ☔ View full report in Codecov by Sentry. |
|
Is this ready for review @ianmkenney? |
|
@dotsdl ready for review, just had to expand tests |
|
Reviewing now! Thanks @ianmkenney! |
- Added `AlchemiscaleClient.create_bulk_tasks` - Added `api.create_bulk_tasks` - Updated `AlchemiscaleClient.create_tasks` - Added tests for `AlchemiscaleClient.create_bulk_tasks`
dotsdl
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Looking great @ianmkenney! A few things to hit yet to improve it further, but this is already a big improvement.
PEFORMS the same Transformation
- Docstring for `create_transformations_tasks` - Only report the Tasks ScopedKey in extends validation
dotsdl
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the$n=1$ task created is the same. When creating thousands of tasks, the runtime drops to about one fifth of its previous value (~23 s to 4 s).
create_tasksmethod to theNeo4jStore. It attempts to minimize the queries made to the database when creating and extending tasks. From local tests, the performance for