Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for create_network in interface API, properly deserializing AlchemicalNetwork #276

Merged
merged 4 commits into from
Jun 5, 2024

Commits on May 30, 2024

  1. Fix for create_network in interface API, properly deserializing Alche…

    …micalNetwork
    
    Previously, we were relying on `fastapi` to decode the JSON form of the
    request, which was not using `gufe.tokenization.JSON_HANDLER.decoder`.
    This resulted in `Settings` objects not being turned into `pydantic`
    models from `dict` form, which silently worked until now before changes
    in `gufe` for 1.0, in which `Protocol` now requires `settings` to be an
    actual `Settings` object on init.
    dotsdl authored and ianmkenney committed May 30, 2024
    Configuration menu
    Copy the full SHA
    578dd9e View commit details
    Browse the repository at this point in the history
  2. Fixed bug in n4js_preloaded for compute testing

    Since the "incomplete" network's edges are a subset of the full network,
    we need to select transformations from the "incomplete" network. Without
    this, there is a small chance that a Transformation is not part of the
    incomplete network, which, in our tests we always assume the attached
    TaskHub has three available tasks available to claim. Additionally, I've
    added a couple more assertions checking these assumptions.
    ianmkenney committed May 30, 2024
    Configuration menu
    Copy the full SHA
    8fd4fa2 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    bad59fa View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Configuration menu
    Copy the full SHA
    6d5fbac View commit details
    Browse the repository at this point in the history