Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed "admin routing compatibility mode" for extensions #1551

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Removed "admin routing compatibility mode" for extensions #1551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
05e9e08
Remove admin router compatibility
luigifab Mar 12, 2021
f46d3f9
Merge branch '20.0' into remove-routing-compat
fballiano Jan 3, 2023
bf4d05f
Merge branch 'next' into remove-routing-compat
fballiano Jul 4, 2023
49b69b3
Merge branch 'next' into remove-routing-compat
fballiano Jul 19, 2023
830f802
Merge branch 'next' into remove-routing-compat
fballiano Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions app/code/core/Mage/Core/Controller/Varien/Router/Admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,10 @@ public function collectRoutes($configArea, $useRouterName)
*/
public function addModule($frontName, $moduleName, $routeName)
{
$isExtensionsCompatibilityMode = (bool)(string)Mage::getConfig()->getNode(
'default/admin/security/extensions_compatibility_mode'
);
$configRouterFrontName = (string)Mage::getConfig()->getNode(
Mage_Adminhtml_Helper_Data::XML_PATH_ADMINHTML_ROUTER_FRONTNAME
);
if ($isExtensionsCompatibilityMode || ($frontName == $configRouterFrontName)) {
if ($frontName == $configRouterFrontName) {
return parent::addModule($frontName, $moduleName, $routeName);
} else {
return $this;
Expand Down
1 change: 0 additions & 1 deletion app/code/core/Mage/Core/etc/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,6 @@
<use_form_key>1</use_form_key>
<domain_policy_backend>2</domain_policy_backend>
<domain_policy_frontend>2</domain_policy_frontend>
<extensions_compatibility_mode>1</extensions_compatibility_mode>
<session_cookie_lifetime>10800</session_cookie_lifetime>
<secure_system_configuration_save_disabled>0</secure_system_configuration_save_disabled>
</security>
Expand Down
10 changes: 0 additions & 10 deletions app/code/core/Mage/Core/etc/system.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,16 +1246,6 @@
<show_in_website>0</show_in_website>
<show_in_store>0</show_in_store>
</domain_policy_frontend>
<extensions_compatibility_mode translate="label comment">
<label>Admin routing compatibility mode for extensions</label>
<comment>Enabling this setting increases risk of automated attacks against admin functionality.</comment>
<frontend_type>select</frontend_type>
<sort_order>6</sort_order>
<source_model>adminhtml/system_config_source_enabledisable</source_model>
<show_in_default>1</show_in_default>
<show_in_website>0</show_in_website>
<show_in_store>0</show_in_store>
</extensions_compatibility_mode>
<crate_admin_user_notification translate="label comment">
<label>New Admin User Create Notification</label>
<comment>This setting enable notification when new admin user created.</comment>
Expand Down
2 changes: 0 additions & 2 deletions app/locale/en_US/Mage_Core.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"Admin","Admin"
"Admin Base URL","Admin Base URL"
"Admin User Emails","Admin User Emails"
"Admin routing compatibility mode for extensions","Admin routing compatibility mode for extensions"
"Advanced","Advanced"
"Advanced Cache Settings","Advanced Cache Settings"
"After selecting a new media storage location, press the Synchronize button
Expand Down Expand Up @@ -133,7 +132,6 @@
"Enabled for Admin","Enabled for Admin"
"Enabled for Frontend","Enabled for Frontend"
"Enabling ability to run Magento in a frame is not recommended for security reasons.","Enabling ability to run Magento in a frame is not recommended for security reasons."
"Enabling this setting increases risk of automated attacks against admin functionality.","Enabling this setting increases risk of automated attacks against admin functionality."
"Environment Update Time","Environment Update Time"
"Error in file: ""%s"" - %s","Error in file: ""%s"" - %s"
"European Union Countries","European Union Countries"
Expand Down
Loading