Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add magento-composer-installer to allowed plugins #2296

Merged

Conversation

elidrissidev
Copy link
Member

@elidrissidev elidrissidev commented Jul 8, 2022

Description (*)

A recent change in Composer regarding the allow-plugins config been causing the Sonar workflow to fail with error message:

magento-hackathon/magento-composer-installer contains a Composer plugin which is blocked by your allow-plugins config. You may add it to the list if you consider it safe.

This PR will add magento-hackathon/magento-composer-installer to allowed plugins in composer.json.

Manual testing scenarios (*)

  1. All tests should now pass, hopefully.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the composer Relates to composer.json label Jul 8, 2022
@elidrissidev
Copy link
Member Author

All green! ✅

@elidrissidev elidrissidev marked this pull request as ready for review July 8, 2022 16:43
@elidrissidev elidrissidev merged commit 61e3c4d into OpenMage:1.9.4.x Jul 8, 2022
@elidrissidev elidrissidev deleted the fix/composer-allow-plugin branch July 8, 2022 19:07
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 61e3c4d. ± Comparison against base commit 5bf1ab5.

@fballiano
Copy link
Contributor

I still see a lot of composer errors in the workflow, @elidrissidev do you know what's happening?

@elidrissidev
Copy link
Member Author

@fballiano 20 branch does not contain this fix yet.

@fballiano
Copy link
Contributor

ah oki it's just that, ok

@fballiano
Copy link
Contributor

thanks!

elidrissidev added a commit to elidrissidev/magento-lts that referenced this pull request Jul 22, 2022
elidrissidev added a commit to elidrissidev/magento-lts that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
composer Relates to composer.json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants