Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phpstan: fixed return types (docs only) #2636

Merged
merged 32 commits into from
Oct 17, 2022
Merged

Phpstan: fixed return types (docs only) #2636

merged 32 commits into from
Oct 17, 2022

Commits on Sep 26, 2022

  1. Fixed "should return string but returns false"

    @sreichel
    sreichel committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    a07e1ac View commit details
    Browse the repository at this point in the history

  2. Fixed "should return XYZ but returns false"

    @sreichel
    sreichel committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    7721bce View commit details
    Browse the repository at this point in the history

  3. Fixed "should return array but returns null"

    @sreichel
    sreichel committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    e7c9855 View commit details
    Browse the repository at this point in the history

  4. Fixed "should return string but returns null"

    @sreichel
    sreichel committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    228667f View commit details
    Browse the repository at this point in the history

  5. Fixed "should return int but returns null"

    @sreichel
    sreichel committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    076c936 View commit details
    Browse the repository at this point in the history

  6. Fixed "should return bool but returns"

    @sreichel
    sreichel committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    37359a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2022

  1. Merge branch '1.9.4.x' into phpstan/l3-1

    @sreichel
    sreichel committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    cb79328 View commit details
    Browse the repository at this point in the history

  2. Fixed docs (see comments)

    @sreichel
    sreichel committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    e88b76c View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. Fixed "should return array"

    @sreichel
    sreichel committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    43dda90 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Update app/code/core/Mage/Adminhtml/Block/Widget/Grid/Massaction/Abst… 

    …ract.php

Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
    @sreichel @kiatng
    sreichel and kiatng authored Oct 5, 2022
    Configuration menu
    Copy the full SHA
    fd1f974 View commit details
    Browse the repository at this point in the history

  2. Update app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/A… 

    …pi.php

Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
    @sreichel @kiatng
    sreichel and kiatng authored Oct 5, 2022
    Configuration menu
    Copy the full SHA
    e7ad47e View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Update app/code/core/Mage/Tag/Model/Resource/Tag.php 

    Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
    @sreichel @kiatng
    sreichel and kiatng authored Oct 8, 2022
    Configuration menu
    Copy the full SHA
    a5458b4 View commit details
    Browse the repository at this point in the history

  2. Update app/code/core/Mage/Customer/Block/Form/Register.php 

    Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
    @sreichel @kiatng
    sreichel and kiatng authored Oct 8, 2022
    Configuration menu
    Copy the full SHA
    21f2477 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Added module names to helper(#2617)

    @sreichel
    sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    df83d31 View commit details
    Browse the repository at this point in the history

  2. Get catalog search result collection from engine (#2634)

    @elidrissidev @sreichel
    elidrissidev authored and sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    4c37719 View commit details
    Browse the repository at this point in the history

  3. Add PHP dependencies security check workflow (#2639)

    @elidrissidev @sreichel
    elidrissidev authored and sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    08199f0 View commit details
    Browse the repository at this point in the history

  4. [security-workflow] Fixed cron syntax (#2640)

    @sreichel
    sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    21edb9d View commit details
    Browse the repository at this point in the history

  5. Added OpenMage Contributors Copyright (#2295)

    @justinbeaty @sreichel
    justinbeaty authored and sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    1c8a814 View commit details
    Browse the repository at this point in the history

  6. Added ddev snippets to docs (#2575)

    @sreichel
    sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    82fa9c8 View commit details
    Browse the repository at this point in the history

  7. Improve dev/openmage/install.sh script for newer versions of Docker -… 

    … no longer requires separate compose.
    @colinmollenhour @sreichel
    colinmollenhour authored and sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    f0928c4 View commit details
    Browse the repository at this point in the history

  8. Only run workflows when relevant files change (#2641)

    @elidrissidev @sreichel
    elidrissidev authored and sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    d14d250 View commit details
    Browse the repository at this point in the history

  9. Add back notification popup severity icons URL (#2633)

    @elidrissidev @sreichel
    elidrissidev authored and sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    b5b81b3 View commit details
    Browse the repository at this point in the history

  10. Reduce reprocessed jpeg file size by defaulting quality to 85% (#2629) 

    * Fixed issue #475.

* Removed <frontend_type>text</frontend_type> as it is the default.

* Fixed bug on users not able to modify image quality in backend if deprecated config exists.

* Fixed bug on incorrect check if image quality was not set in backend.

* Improved note in system.xml.
    @kiatng @sreichel
    kiatng authored and sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    3234f93 View commit details
    Browse the repository at this point in the history

  11. Prevented editing of a non-editable order (#2632)

    @elidrissidev @sreichel
    elidrissidev authored and sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    b98a549 View commit details
    Browse the repository at this point in the history

  12. Fix dev/openmage/install.sh script setting permissions on var directory.

    @colinmollenhour @sreichel
    colinmollenhour authored and sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    afe8e06 View commit details
    Browse the repository at this point in the history

  13. Allowed automatic full invoice from API (#2393)

    @luigifab @sreichel
    luigifab authored and sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    f22c9cd View commit details
    Browse the repository at this point in the history

  14. Add check if array key isset before using it (#2649)

    @przemyslaw-p @sreichel
    przemyslaw-p authored and sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    df72c2b View commit details
    Browse the repository at this point in the history

  15. Merge branch '1.9.4.x' into phpstan/l3-1

    @sreichel
    sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    185fb12 View commit details
    Browse the repository at this point in the history

  16. Fixed phpstan-baseline.neon

    @sreichel
    sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    3c82e76 View commit details
    Browse the repository at this point in the history

  17. Fixed phpstan-baseline.neon (updated dev tools)

    @sreichel
    sreichel committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    a8dfa5c View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Revert "Fixed phpstan-baseline.neon" 

    This reverts commit 3c82e76.
    @sreichel
    sreichel committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    66e1aa0 View commit details
    Browse the repository at this point in the history

  2. Fixed getRegion()

    @sreichel
    sreichel committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    d804da9 View commit details
    Browse the repository at this point in the history