Fix bug on clonePosition() in prototype.js. #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADDISON74
approved these changes
Oct 28, 2022
fballiano
approved these changes
Oct 28, 2022
|
To follow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This is a known bug in prototype.js as reported here. But it is actually fixed in the master branch on 3 Jan 2016. The tag 1.7.3 was released on 22 September 2015, without the fix. This PR just copy the updated
clonePosition()from the current master.Fixed Issues (if relevant)
Manual testing scenarios (*)
See example here to test. I have also tested the case provided in prototypejs's issue #248.