Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To be able to run OpenVPN client in Docker container #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtilson
Copy link

@mtilson mtilson commented Jul 2, 2022

The file /etc/resolv.conf is not a regular one in Docker container, it is a bind-mount within container.
It cause cp: can't create '/etc/resolv.conf': File exists error and as a result resolv.conf.ovpnsave is not copied back as it is intended.
But rewriting the file instead of moving or renaming is possible.

The file `/etc/resolv.conf` is not a regular one in Docker container, it is bind-mounts within container.
It cause `cp: can't create '/etc/resolv.conf': File exists` error and as a result `resolv.conf.ovpnsave` is not copied back as it is intended.
But rewriting the file instead of moving or renaming is possible.
@ordex
Copy link
Member

ordex commented Sep 17, 2022

I think this makes sense. @cron2 @dsommers do you have any opinion?

In any case, a proper patch should be eventually sent to the mailing list.

@dsommers
Copy link
Member

this is a contrib script; normally not installed in any default $PATH. I consider these contrib scripts more like templates. Change itself is fine for me.

@ordex
Copy link
Member

ordex commented Sep 19, 2022

@mtilson can we have your SoB line on the patch (preferably sent to the mailing list)?
Otherwise it cannot be processed.

@ordex
Copy link
Member

ordex commented Oct 4, 2022

@mtilson any chance you could address the comments above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants