Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add billing management section when create/edit a Role #369

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nahimdhaney
Copy link

@nahimdhaney nahimdhaney commented Sep 3, 2024

  • Updated the image manage-role-create.png and modified settings.adoc adding the manage role permission explanation.

Should I include things in the changelog.adoc? I noticed looking at the PR history that we only update it when about to release, but happy to include it in a Unreleased section or similar if that makes sense and doesn't show up in the UI.

Copy link
Contributor

@tirumerla tirumerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks. We will slate it to merge after the release of the feature.

@tirumerla
Copy link
Contributor

Should I include things in the changelog.adoc? I noticed looking at the PR history that we only update it when about to release, but happy to include it in a Unreleased section or similar if that makes sense and doesn't show up in the UI.

I think for now this is fine, You can still add it to changelog but we will release the public docs after the release anyways so its safe to add it to changelog. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants