Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for setup and interactive commands, using powershell in Windows #10

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

coreyeng
Copy link
Member

Hi,

I got O2 working in Windows. There were some problems, but I think I've at least the basics worked out. With the updates here, and the few additional steps added to the README, I can get the setup and interactive commands to work.

I think there's still some improvements to make here but this should at get some Windows-side developments going and, given the volatile nature of this project being very early in development, I don't really want to sit on these changes while I continue to learn Rust and risk having merging nightmares later on.

I don't have WSL installed yet, but I'll be doing that pretty soon here and I can start running O2 on both systems. I don't think anything I changed should have affected Linux.

I can give some more details if needed, but most changes boil down to syntax differences between Linux and Windows, and then how Rust handles system commands, which IMO, is really user-unfriendly since no other languages I'm aware of calls commands in that way. Not even C++ or Java.

Thanks!

@coreyeng
Copy link
Member Author

Oh, forgot to mention, Python's readline isn't supported in Windows. I found a pure-python implementation, pyreadline, but it doesn't support the history stuff. I left it in for now if we want to play with it, but I wanted to get some basic Windows supported added. For now, I just added warnings that the history file isn't supported. I don't think it'd be too complicated to homebrew our own, but if we start using other things in the readline library, we may have to differentiate between Windows and Linux.

Copy link
Member

@ginty ginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@coreyeng coreyeng merged commit 86648d1 into master Dec 2, 2019
@coreyeng coreyeng deleted the initial_windows_support branch December 5, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants