Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to set auth cookie key name #266

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

leoralph
Copy link
Contributor

Description

Currently, we can use cookies to send the auth token, but it is not documented and we cannot customize the cookie name.

This PR adds the cookie_key_name config to let us change the auth token cookie and adds documentation to the cookie authentication method.

Checklist:

  • I've added tests for my changes or tests are not applicable
  • I've changed documentations or changes are not required
  • I've added my changes to CHANGELOG.md

Copy link
Collaborator

@Messhias Messhias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. I'll just wait for one more approval and merge it. Thanks @leoralph for your contribution.

Copy link
Contributor

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM but I've two concerns I'm sharing here

src/Http/Parser/Cookies.php Outdated Show resolved Hide resolved
src/Providers/LaravelServiceProvider.php Outdated Show resolved Hide resolved
@leoralph
Copy link
Contributor Author

In general LGTM but I've two concerns I'm sharing here

@mfn Thanks for the review, I have applied the fixes.

@leoralph leoralph requested a review from mfn September 27, 2024 16:54
Copy link
Contributor

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@Messhias Messhias merged commit 460edf5 into PHP-Open-Source-Saver:main Sep 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants