Remove indentation from the request payload JSON #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, interesting. I assume you confirmed with this change, it is now working with ZeroSSL or similar implementations? |
|
Yes, removing the indentation worked correctly. It's very strange. I am working on the EAB support now and the following code confirms that it works. Although not included in the PR, ACMESharpCore directly incorporates the version with the indentation removed. Error message:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Believe it or not, some ACME implementations return an error if there is indentation in the JSON of the request payload.
win-acme/win-acme#1565
I noticed this problem in the ACME implementation of ZeroSSL.