Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for multi-account #119

Merged
merged 5 commits into from
Jul 12, 2024
Merged

feat: add support for multi-account #119

merged 5 commits into from
Jul 12, 2024

Conversation

t1agob
Copy link
Contributor

@t1agob t1agob commented Jul 12, 2024

Description

This PR introduces support for multi-account configuration. With this PR admins will be able to specify multiple PagerDuty accounts in the same Backstage instance. Support was added across all the components of the plugin:

  • Backend: All API routes exposed take account as an optional parameter so you can create and query information from different PagerDuty Accounts. If admins leverage the Entity Mapping feature, the account is now persisted into the plugin database.
  • Scaffolder Actions: When the scaffolder action is used on a template it now lists Escalation Policies from all accounts configured so the user can easily select the one they want. The Scaffolder action also outputs the account so it can be replaced in the app-config.yaml annotations.
  • Entity Processor: If an entity mapping stored in the plugin database contains the account property, the processor will add an annotation to the entity with its information.

This PR solves an existing problem for many large organizations that have several PagerDuty accounts for segregation purposes or that result from company acquisitions.

Issue number: #96

Type of change

  • New feature (non-breaking change which adds functionality)
  • Fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
  • Changes generate no new warnings
  • PR title follows conventional commit semantics

If this is a breaking change 👇

  • I have documented the migration process
  • I have implemented necessary warnings (if it can live side by side)

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Signed-off-by: Tiago Barbosa <tbarbos@hotmail.com>
Signed-off-by: Tiago Barbosa <tbarbos@hotmail.com>
Signed-off-by: Tiago Barbosa <tbarbos@hotmail.com>
Signed-off-by: Tiago Barbosa <tbarbos@hotmail.com>
@t1agob t1agob added the enhancement New feature or request label Jul 12, 2024
@t1agob t1agob merged commit 6cb2fda into next Jul 12, 2024
4 checks passed
@t1agob t1agob deleted the feat/advanced-config-page branch July 12, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant