Option to specify Nagios fields from environment variables #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it out and it works as advertised! It handles quotes with no problems now. Thanks! |
divtxt
force-pushed
the
nagios-params-from-env
branch
from
4724821
to
c627fb9
Compare
divtxt
force-pushed
the
nagios-params-from-env
branch
from
c627fb9
to
f1e9903
Compare
|
Added ICINGA support |
| v = os.environ.get("NAGIOS_%s" % f) | ||
| if v is None: | ||
| v = os.environ.get("ICINGA_%s" % f) | ||
| if v is None: |
There was a problem hiding this comment.
should we just do something like this instead?
if v is not None:
details[f] = vOtherwise, I imagine we'll be creating events with some "" => "" details fields.
There was a problem hiding this comment.
Could do. Though I'm not sure you'd get a blank key? I was leaning towards always sending the field even if the value is blank so that the user knows there's no bug in the pd parts of the stack.
There was a problem hiding this comment.
Oh, I see. Yeah, this seems good.
divtxt
force-pushed
the
nagios-params-from-env
branch
from
499b571
to
4fa5297
Compare
| return | ||
| from os import environ | ||
| for f in env_fields: | ||
| details[f] = environ.get("NAGIOS_%s" % f) or environ.get("ICINGA_%s" % f) or "" |
|
Nice! |
|
@mdcollins05 - would appreciate it if you can test the latest version on aws. (icinga testing too if that's easy) No rush. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdcollins05 - please try this out.
-f FOO="$FOO"viacommand_linecan also be sent by-e FOOI just picked
-e/--env-field- other suggestions welcomecc @chamblin