Fix git tag in rockspec #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current rockspec does not work with Luarocks because there is no "v0.8.1" tag in the repository.
To fix this either replace the tag specified in the rockspec (this PR does this), or add a "v0.8.1" tag to the repository to retrospectively make the rockspec correct.
Side note:
I think you may be misunderstanding how versioning works in luarocks, the
-is supposed to separate the version of the package from the revision of the rockspec itself (see version in https://github.com/luarocks/luarocks/wiki/Rockspec-format#package-metadata).So say if you're preparing to release v0.8.1 of your library - the rockspec version should read
0.8.1-1as its the1st revision of the rockspec file for the package version0.8.1.By the same logic rockspec version
0.8-1should correspond to the1st rockspec file revision of package version0.8- so should probably use the tagv0.8.