Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'make (un)install' commands #96

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

mitchnielsen
Copy link
Contributor

@mitchnielsen mitchnielsen commented Sep 25, 2024

Summary

The wildcard in the 'make (un)install' commands was causing an error locally. At least on my system and shell (zsh), adding the single quotes around the file path fixes it.

Related to https://linear.app/prefect/issue/PLA-289/cycle-2-catch-all

Testing

Before the change:

$ make install
mise all runtimes are installed
pre-commit installed at /Users/mitch/code/github.com/prefecthq/prefect-operator/main/.git/hooks/pre-commit
controller-gen crd webhook paths="./..." output:crd:artifacts:config=deploy/charts/prefect-operator/crds
kubectl apply -f deploy/charts/prefect-operator/crds/*.yaml
error: Unexpected args: [deploy/charts/prefect-operator/crds/prefect.io_prefectworkpools.yaml]
See 'kubectl apply -h' for help and examples
make: *** [install] Error 1

After the change:

$ make install
mise all runtimes are installed
pre-commit installed at /Users/mitch/code/github.com/prefecthq/prefect-operator/main/.git/hooks/pre-commit
controller-gen crd webhook paths="./..." output:crd:artifacts:config=deploy/charts/prefect-operator/crds
kubectl apply -f 'deploy/charts/prefect-operator/crds/*.yaml'
customresourcedefinition.apiextensions.k8s.io/prefectservers.prefect.io unchanged
customresourcedefinition.apiextensions.k8s.io/prefectworkpools.prefect.io unchanged

The wildcard in the 'make (un)install' commands was causing an error
locally. At least on my system and shell (zsh), adding the single quotes
around the file path fixes it.

Related to https://linear.app/prefect/issue/PLA-289/cycle-2-catch-all
@mitchnielsen mitchnielsen self-assigned this Sep 25, 2024
@mitchnielsen mitchnielsen marked this pull request as ready for review September 25, 2024 19:21
@mitchnielsen mitchnielsen merged commit 5f3d8b6 into main Sep 25, 2024
4 checks passed
@mitchnielsen mitchnielsen deleted the fix-install-uninstall branch September 25, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants