Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate PyModule trait bounds #4594

Merged
merged 1 commit into from
Oct 4, 2024
Merged

migrate PyModule trait bounds #4594

merged 1 commit into from
Oct 4, 2024
+24 −18

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Oct 4, 2024

Migrates various PyModule related functionality to IntoPyObject.

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Oct 4, 2024
davidhewitt
davidhewitt approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@davidhewitt davidhewitt added this pull request to the merge queue Oct 4, 2024
Merged via the queue into PyO3:main with commit d4ad8a2 Oct 4, 2024
42 of 43 checks passed
@Icxolu Icxolu deleted the migrate-pymodulemethods branch October 5, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Icxolu @davidhewitt