Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QDevil QDAC2: Remove current limit until fully implemented in instrument #136

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

jpsecher
Copy link
Contributor

@jpsecher jpsecher commented Jun 8, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #136 (720842e) into master (c824b73) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   19.36%   19.25%   -0.12%     
==========================================
  Files         123      123              
  Lines       14679    14659      -20     
==========================================
- Hits         2843     2823      -20     
  Misses      11836    11836              
Impacted Files Coverage Δ
...b_drivers/tests/QDevil/test_sim_qdac2_source_dc.py 100.00% <ø> (ø)
...drivers/tests/QDevil/test_sim_qdac2_source_list.py 100.00% <ø> (ø)
.../tests/QDevil/test_sim_qdac2_source_output_mode.py 100.00% <ø> (ø)
qcodes_contrib_drivers/drivers/QDevil/QDAC2.py 96.37% <100.00%> (-0.02%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpsecher shall i make a patch release of qcodes_contrib_drivers with this change today?

@astafan8 astafan8 enabled auto-merge June 8, 2022 08:32
@astafan8 astafan8 merged commit 3f82bee into QCoDeS:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants