Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace version in actions with dynamic value #1073

Merged
merged 17 commits into from
Feb 1, 2022
Merged

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Jan 30, 2022

Fix the version replace with a dynamic value

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)

Siehe #1072 Version 3.5.2 wird immer wieder eingesetzt.

  • What is the new behavior (if this is a feature change)?

Es wird nach einer Version aus drei Zahlen getrennt durch Punkte gesucht.
Der 2. gefundene Wert wird verwendet. In diesem Fall steht der 2. Wert in der 2. Zeile = 3.5.4

# $Id: 00_SIGNALduino.pm v3.5.4 2022-01-31 21:29:55Z sidey79 $
# v3.5.4 - https://github.com/RFD-FHEM/RFFHEM/tree/master
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Nein, jedoch hat es Auswirkungen, wenn die 2. Zeile entfernt werden würde was als version verwendet wird.

  • Other information:

Fix the version replace with a dynamic value
@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #1073 (a293640) into master (d77ac00) will increase coverage by 1.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1073      +/-   ##
==========================================
+ Coverage   63.29%   64.47%   +1.18%     
==========================================
  Files         127      128       +1     
  Lines        9358     9383      +25     
  Branches     1477     1480       +3     
==========================================
+ Hits         5923     6050     +127     
+ Misses       2304     2199     -105     
- Partials     1131     1134       +3     
Flag Coverage Δ
fhem 56.23% <ø> (+1.35%) ⬆️
modules 64.47% <ø> (+1.18%) ⬆️
perl 91.85% <ø> (+0.21%) ⬆️
unittests 64.47% <ø> (+1.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
t/FHEM/14_SD_BELL/00_load.t
t/FHEM/14_BresserTemeo/00_load.t 100.00% <0.00%> (ø)
t/FHEM/14_SD_WS07/09_parseDatat.t 80.00% <0.00%> (ø)
FHEM/lib/SD_Protocols.pm 79.81% <0.00%> (+0.57%) ⬆️
FHEM/10_SD_Rojaflex.pm 72.76% <0.00%> (+4.06%) ⬆️
FHEM/00_SIGNALduino.pm 68.02% <0.00%> (+4.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77ac00...a293640. Read the comment docs.

@sidey79 sidey79 marked this pull request as ready for review January 31, 2022 21:42
@sidey79 sidey79 self-assigned this Jan 31, 2022
@sidey79 sidey79 linked an issue Jan 31, 2022 that may be closed by this pull request
fix file changes
@sidey79 sidey79 merged commit 4ee9399 into master Feb 1, 2022
@sidey79 sidey79 deleted the fix-versionReplace branch February 1, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hideki Match Regex
3 participants